public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Andrei Perapiolkin via pve-devel <pve-devel@lists.proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Andrei Perapiolkin <andrei.perepiolkin@open-e.com>
Subject: [pve-devel] Handling 'path' requests during VM deletion
Date: Thu, 7 Aug 2025 17:34:02 -0400	[thread overview]
Message-ID: <mailman.714.1754602793.367.pve-devel@lists.proxmox.com> (raw)

[-- Attachment #1: Type: message/rfc822, Size: 7000 bytes --]

From: Andrei Perapiolkin <andrei.perepiolkin@open-e.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] Handling 'path' requests during VM deletion
Date: Thu, 7 Aug 2025 17:34:02 -0400
Message-ID: <ec1c3036-4783-4c3a-baf0-a32d883dc852@open-e.com>

Hi,

VM deletion retries 'path'/'free_image' for already-removed volumes; 
expected plugin behavior on missing volumes is unclear.

When deleting a VM with multiple attached volumes, Proxmox deletes 
volumes sequentially (one at a time) and
updates the VM record only after all deletions complete.
If a volume deletion fails mid-process (e.g., network error), the VM 
record is not updated even though some volumes may have been 
successfully removed.
A subsequent delete attempt repeats all operations, including 'path' 
(and 'free_image') calls for volumes that were already deleted.


What is the proper response to 'path' and 'free_image' calls for a 
volume that no longer exists?
For path, should the call fail (e.g., 'die'), succeed with an empty 
string, or return a 'storage path'?


Tested on Proxmox VE 8.4.0

Best regards,
Andrei Perepiolkin



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

             reply	other threads:[~2025-08-07 21:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 21:34 Andrei Perapiolkin via pve-devel [this message]
2025-08-14 15:11 ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.714.1754602793.367.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=andrei.perepiolkin@open-e.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal