Re: [pve-devel] [PATCH container v2] api: record CT ID as used after a container is destroyed

[Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 4410 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: a.lauterer@proxmox.com
Cc: pve-devel@lists.proxmox.com, t.lamprecht@proxmox.com
Subject: Re: [pve-devel] [PATCH container v2] api: record CT ID as used after a container is destroyed
Date: Tue, 5 Nov 2024 13:53:41 +1300
Message-ID: <ba5t63z7iwekm7iejhguzrjxlnpp2d27a4j7flrdcmxturpkfq@lsioezbx572v>

Hi Aaron,

On Thu, Oct 31, 2024 at 06:27:43PM +0100, Aaron Lauterer wrote:
> This is missing a
> 
> use PVE::UsedVmidList;
> 
> at the top of the file. Otherwise running
> 
> pct destroy {vmid}
> 
> will result in the following error:
> 
> Undefined subroutine &PVE::UsedVmidList::add_vmid called at
> /usr/share/perl5/PVE/API2/LXC.pm line 799.
> 
> This doesn't seem to be necessary in the qemu-server repo, but I did not
> investigate further how pulling in dependencies works there.

Thanks for catching this! It's strange that it's not necessary in
`PVE::API2::Qemu`... Either way, I think it makes sense to explicitly use the
module in both files, so I'll update the patches to do that.

Thanks,
Severen


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel