Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist

[Lou Lecrivain via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13357 bytes --]

From: <Lou.Lecrivain@wdz.de>
To: <s.hanreich@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: RE: Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist
Date: Fri, 6 Dec 2024 10:33:12 +0000
Message-ID: <BE1P281MB2116CD2E4955A8FC9A86907085312@BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM>

Re,

Seems like I did not test this enough, whoops.

> Maybe it would make sense to move the whole code of configure_range to
> configure_subnet in the Dnsmasq plugin, since the whole subnet gets
> configured anyway and make configure_range a noop?
Yes, do agree on this one. I think it'd be cleaner in terms of code.

I'll take this into account for next version. Thanks.

BR
________________________________________
De : Stefan Hanreich <s.hanreich@proxmox.com>
Envoyé : jeudi 5 décembre 2024 17:20
À : Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain@wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist
 
Seems like this still is a remnant from when we used to configure the
ranges explicitly dhcp-range. But adding two DHCP ranges just generates
two identical lines in the dnsmasq config:

> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite
> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite

Maybe it would make sense to move the whole code of configure_range to
configure_subnet in the Dnsmasq plugin, since the whole subnet gets
configured anyway and make configure_range a noop?


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel