* [pve-devel] [PATCH pve-storage] lvmplugin: fix: activate|deactivate volume, add missing storeid param in path sub
@ 2024-09-25 9:00 Alexandre Derumier via pve-devel
2024-10-22 10:56 ` [pve-devel] applied: " Fiona Ebner
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Derumier via pve-devel @ 2024-09-25 9:00 UTC (permalink / raw)
To: pve-devel; +Cc: Alexandre Derumier
[-- Attachment #1: Type: message/rfc822, Size: 3990 bytes --]
From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-storage] lvmplugin: fix: activate|deactivate volume, add missing storeid param in path sub
Date: Wed, 25 Sep 2024 11:00:45 +0200
Message-ID: <20240925090045.768188-1-alexandre.derumier@groupe-cyllene.com>
$storeid param is missing and $snapname is used as third param.
This seem to works actually because $snapname is always empty in lvm
Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
---
src/PVE/Storage/LVMPlugin.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 4b951e7..88fd612 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -532,7 +532,7 @@ sub deactivate_storage {
sub activate_volume {
my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
#fix me lvmchange is not provided on
- my $path = $class->path($scfg, $volname, $snapname);
+ my $path = $class->path($scfg, $volname, $storeid, $snapname);
my $lvm_activate_mode = 'ey';
@@ -545,7 +545,7 @@ sub activate_volume {
sub deactivate_volume {
my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
- my $path = $class->path($scfg, $volname, $snapname);
+ my $path = $class->path($scfg, $volname, $storeid, $snapname);
return if ! -b $path;
my $cmd = ['/sbin/lvchange', '-aln', $path];
--
2.39.2
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH pve-storage] lvmplugin: fix: activate|deactivate volume, add missing storeid param in path sub
2024-09-25 9:00 [pve-devel] [PATCH pve-storage] lvmplugin: fix: activate|deactivate volume, add missing storeid param in path sub Alexandre Derumier via pve-devel
@ 2024-10-22 10:56 ` Fiona Ebner
0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2024-10-22 10:56 UTC (permalink / raw)
To: Proxmox VE development discussion
Am 25.09.24 um 11:00 schrieb Alexandre Derumier via pve-devel:
> $storeid param is missing and $snapname is used as third param.
>
> This seem to works actually because $snapname is always empty in lvm
>
> Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-22 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-25 9:00 [pve-devel] [PATCH pve-storage] lvmplugin: fix: activate|deactivate volume, add missing storeid param in path sub Alexandre Derumier via pve-devel
2024-10-22 10:56 ` [pve-devel] applied: " Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox