From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>,
t.lamprecht@proxmox.com
Subject: [pve-devel] [PATCH container v4] api: record CT ID as used after a container is destroyed
Date: Fri, 8 Nov 2024 14:46:20 +1300 [thread overview]
Message-ID: <mailman.64.1731030431.372.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20241108014620.73352-1-severen.redwood@sitehost.co.nz>
[-- Attachment #1: Type: message/rfc822, Size: 4325 bytes --]
From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: pve-devel@lists.proxmox.com
Cc: a.lauterer@proxmox.com, t.lamprecht@proxmox.com, Severen Redwood <severen.redwood@sitehost.co.nz>, Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Subject: [PATCH container v4] api: record CT ID as used after a container is destroyed
Date: Fri, 8 Nov 2024 14:46:20 +1300
Message-ID: <20241108014620.73352-6-severen.redwood@sitehost.co.nz>
After a container is destroyed, record that its ID has been used via the
`PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
Tested-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
Changed since v3 is removing an unnecessary `qw(add_vmid)` after
`use PVE::UsedVmidList`.
src/PVE/API2/LXC.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 213e518..e35b26d 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -28,6 +28,7 @@ use PVE::API2::LXC::Config;
use PVE::API2::LXC::Status;
use PVE::API2::LXC::Snapshot;
use PVE::JSONSchema qw(get_standard_option);
+use PVE::UsedVmidList;
use base qw(PVE::RESTHandler);
BEGIN {
@@ -794,7 +795,9 @@ __PACKAGE__->register_method({
}
}
- # only now remove the zombie config, else we can have reuse race
+ # only now mark the CT ID as previously used and remove the zombie
+ # config, else we can have reuse race
+ PVE::UsedVmidList::add_vmid($vmid);
PVE::LXC::Config->destroy_config($vmid);
};
--
2.47.0
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-08 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 1:44 [pve-devel] [PATCH SERIES v4] Add ability to prevent suggesting previously used VM/CT IDs Severen Redwood via pve-devel
2024-11-08 1:46 ` [pve-devel] [PATCH manager v4 1/2] close #4369: api: optionally only suggest unique IDs Severen Redwood via pve-devel
[not found] ` <20241108014620.73352-1-severen.redwood@sitehost.co.nz>
2024-11-08 1:46 ` [pve-devel] [PATCH manager v4 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Severen Redwood via pve-devel
2024-11-08 1:46 ` [pve-devel] [PATCH cluster v4 1/2] cluster files: add used_vmids.list Severen Redwood via pve-devel
2024-11-08 1:46 ` [pve-devel] [PATCH cluster v4 2/2] datacenter config: add unique-next-id to schema Severen Redwood via pve-devel
2024-11-08 1:46 ` [pve-devel] [PATCH qemu-server v4] api: record VM ID as used after a virtual machine is destroyed Severen Redwood via pve-devel
2024-11-08 1:46 ` Severen Redwood via pve-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.64.1731030431.372.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=severen.redwood@sitehost.co.nz \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox