Re: [pve-devel] [PATCH qemu-server 12/14] qemu_img convert : add external snapshot support

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13898 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 12/14] qemu_img convert : add external snapshot support
Date: Tue, 27 May 2025 14:49:01 +0000
Message-ID: <b6b1668a3237f7c6704f87f5e1402bd06d881c72.camel@groupe-cyllene.com>

>>
>>has_features->{snapshot}->{raw} = 1 :  it's always a storage snapshot
>>(assuming we don't want to implement external qcow2 snapshot with raw
>>backing)
>>
>>has_features->{snapshot}->{qcow2|other_format_than_raw)} = 1 :  qemu
>>internal snapshot
>>has_features->{snapshot}->{qcow2} = 2 :  qemu external snapshot

ah sorry, I speak too fast, rbd is raw, but use qemu internal feature
snapshot to take snasphot, but don't pass the option in qemu-img
convert.

maybe for convert, we need to keep the check for qcow2 format (as it's
the only format working with "-l snapshot.name" option anyway) +  if
the snapshot is external|internal


I need to think a little bit more about this







[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel