Re: [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs

Re: [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs

[Aaron Lauterer]

gave this series another spin in my test cluster and so far it seems to 
work as described.
I did a very quick test if we see some noticeable "lag" when destroying 
a guest by filling the `used_vmids.list` with IDs from 100..30000 and a 
stepsize of 2, so close to 15k lines. But I didn't notice that it would 
take longer.

A few small style nits are addressed, in the specific patches. But 
nothing severe that would justify a v4 right away.

Consider this series:

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2024-11-05  02:58, Severen Redwood wrote:
> Hi everyone,
> 
> This is a small update to my previous patch series [1, 2]
> adding optional support for preventing PVE from suggesting
> previously used VM/CT IDs.
> 
> In particular, missing use statements have been added to the
> patches for marking VM/CT IDs as used, as noticed by Aaron
> [3]. Everything else remains the same as in v2.
> 
> Also note when building this patch series that the pve-cluster
> patches must be applied and built first to prevent the build
> of pve-manager from failing.
> 
> If anyone has any other feedback, please let me know.
> 
> Thanks,
> Severen
> 
> [1]: https://lore.proxmox.com/pve-devel/mailman.177.1728018639.332.pve-devel@lists.proxmox.com/
> [2]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#t
> [3]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#m7313a65f5b26f29ff0a2b4005069a7306311ccf6
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs

[Severen Redwood via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 3681 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: Aaron Lauterer <a.lauterer@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs
Date: Fri, 8 Nov 2024 13:44:39 +1300
Message-ID: <0d5cd0df-09c9-451d-a8c3-e0a777dd783b@sitehost.co.nz>

Hi Aaron,

Thanks for the review and testing! I'll post v4 today to
address your comments and add those commit trailers.

Thanks,
Severen


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs

[Severen Redwood via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4438 bytes --]

From: "Severen Redwood" <severen.redwood@sitehost.co.nz>
To: <pve-devel@lists.proxmox.com>
Cc: "Aaron Lauterer" <a.lauterer@proxmox.com>, "Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs
Date: Tue, 05 Nov 2024 14:58:08 +1300
Message-ID: <D5DVFH6OZLBN.2KLGTH53ZHGNJ@sitehost.co.nz>

Hi everyone,

This is a small update to my previous patch series [1, 2]
adding optional support for preventing PVE from suggesting
previously used VM/CT IDs.

In particular, missing use statements have been added to the
patches for marking VM/CT IDs as used, as noticed by Aaron
[3]. Everything else remains the same as in v2.

Also note when building this patch series that the pve-cluster
patches must be applied and built first to prevent the build
of pve-manager from failing.

If anyone has any other feedback, please let me know.

Thanks,
Severen

[1]: https://lore.proxmox.com/pve-devel/mailman.177.1728018639.332.pve-devel@lists.proxmox.com/
[2]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#t
[3]: https://lore.proxmox.com/pve-devel/mailman.624.1730255368.332.pve-devel@lists.proxmox.com/T/#m7313a65f5b26f29ff0a2b4005069a7306311ccf6


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel