public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [pve-devel] [PATCH pve-network] SDN: Dhcp: perl 5.40 compat
Date: Sat, 23 Nov 2024 15:19:36 +0900	[thread overview]
Message-ID: <mailman.602.1732342880.391.pve-devel@lists.proxmox.com> (raw)

[-- Attachment #1: Type: message/rfc822, Size: 7437 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-network] SDN: Dhcp: perl 5.40 compat
Date: Sat, 23 Nov 2024 15:19:36 +0900
Message-ID: <20241123062041.1641221-1-jing@jing.rocks>

On trixie with perl 5.40 we see these errors:

Nov 14 06:28:54 pi16 pve-firewall[932]: Attempt to call undefined import method with arguments ("config") via package "PVE::Network::SDN::Dhcp" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 10, <DATA> line 960.
Nov 14 06:28:54 pi16 pve-firewall[932]: Attempt to call undefined import method with arguments ("sdn_subnets_config" ...) via package "PVE::Network::SDN::Subnets" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 12, <DATA> line 960.
Nov 14 06:28:54 pi16 pvestatd[904]: Attempt to call undefined import method with arguments ("config") via package "PVE::Network::SDN::Dhcp" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 10, <DATA> line 960.
Nov 14 06:28:54 pi16 pvestatd[904]: Attempt to call undefined import method with arguments ("sdn_subnets_config" ...) via package "PVE::Network::SDN::Subnets" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 12, <DATA> line 960.
Nov 14 06:28:54 pi16 pvedaemon[1126]: Attempt to call undefined import method with arguments ("config") via package "PVE::Network::SDN::Dhcp" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 10, <DATA> line 960.
Nov 14 06:28:54 pi16 pvedaemon[1126]: Attempt to call undefined import method with arguments ("sdn_subnets_config" ...) via package "PVE::Network::SDN::Subnets" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.pm line 12, <DATA> line 960.

So let's fix it. No regression for bookworm so far.

Signed-off-by: Jing Luo <jing@jing.rocks>
---
probably should've opened a ticket on bugzilla? anyways...
---
 src/PVE/Network/SDN/Dhcp.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/SDN/Dhcp.pm
index d48de34..c42e730 100644
--- a/src/PVE/Network/SDN/Dhcp.pm
+++ b/src/PVE/Network/SDN/Dhcp.pm
@@ -7,9 +7,9 @@ use PVE::Cluster qw(cfs_read_file);
 
 use PVE::Network::SDN;
 use PVE::Network::SDN::SubnetPlugin;
-use PVE::Network::SDN::Dhcp qw(config);
+use PVE::Network::SDN::Dhcp;
 use PVE::Network::SDN::Ipams;
-use PVE::Network::SDN::Subnets qw(sdn_subnets_config config get_dhcp_ranges);
+use PVE::Network::SDN::Subnets;
 use PVE::Network::SDN::Dhcp::Plugin;
 use PVE::Network::SDN::Dhcp::Dnsmasq;
 
-- 
2.47.0




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

                 reply	other threads:[~2024-11-23  6:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.602.1732342880.391.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=jing@jing.rocks \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal