public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type
@ 2024-06-07  9:43 Jing Luo via pve-devel
  0 siblings, 0 replies; 7+ messages in thread
From: Jing Luo via pve-devel @ 2024-06-07  9:43 UTC (permalink / raw)
  To: pve-devel; +Cc: Jing Luo

[-- Attachment #1: Type: message/rfc822, Size: 5444 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type
Date: Fri,  7 Jun 2024 18:43:23 +0900
Message-ID: <20240607094734.3883693-1-jing@jing.rocks>

gcc warns (-Werror=type-limits) that it will always be false for the
if statement. This is because here s->aid is defined as char, while
proxmox_restore_open_image() returns an int. Change the type to int.
Strangely gcc warns it on arm64 build but not amd64 build...

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 ...2-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
index b9578ba..9e68167 100644
--- a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
+++ b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
@@ -68,7 +68,7 @@ index 0000000000..dd72356bd3
 +
 +typedef struct {
 +    ProxmoxRestoreHandle *conn;
-+    char aid;
++    int aid;
 +    int64_t length;
 +
 +    char *repository;
-- 
2.45.2




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-06-11 10:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240607094734.3883693-1-jing@jing.rocks>
2024-06-07 11:49 ` [pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type Fiona Ebner
2024-06-10  1:48   ` Jing Luo via pve-devel
     [not found]   ` <57a95560b7c8bce55d2e8270d18d9778@jing.rocks>
2024-06-10  9:27     ` Fiona Ebner
2024-06-10 12:05       ` [pve-devel] [PATCH v2 pve-qemu-kvm] patches: " Jing Luo via pve-devel
     [not found]       ` <20240610122909.1216178-2-jing@jing.rocks>
2024-06-10 14:12         ` [pve-devel] applied: " Fiona Ebner
2024-06-10  8:53 ` [pve-devel] [PATCH pve-qemu-kvm] patch: " Shannon Sterz
2024-06-07  9:43 Jing Luo via pve-devel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal