public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gilberto Ferreira via pve-devel <pve-devel@lists.proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Gilberto Ferreira <gilberto.nunes32@gmail.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages
Date: Wed, 20 Nov 2024 13:32:05 -0300	[thread overview]
Message-ID: <mailman.512.1732120371.391.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 8768 bytes --]

From: Gilberto Ferreira <gilberto.nunes32@gmail.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>, d.csapak@proxmox.com
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages
Date: Wed, 20 Nov 2024 13:32:05 -0300
Message-ID: <CAOKSTBvy5hemAM1+9rV8Y_Z1vZ_gCy5JtUJSxFmRTJVQDLbtNw@mail.gmail.com>

Hi there.
Sorry for the email, but I tested this import option with an Ubuntu ova
which has space in the vmdk name and I believe that could lead to errors.
I had downloaded from here:
https://razaoinfo.dl.sourceforge.net/project/osboxes/v/vb/55-U-u/OVA-Versions/24.04/Ubuntu-24.04-64bit-VB.ova
When I tried to import got error 500!
Unfortunately I didn't get the entire error message or any logs.
Is it some kind of error or bug?

Nevertheless, I would like to say thanks for this amazing feature.

Cheers






Em ter., 19 de nov. de 2024 às 05:49, Thomas Lamprecht <
t.lamprecht@proxmox.com> escreveu:

> Am 19.11.24 um 09:15 schrieb Lukas Wagner:
> > On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
> >>>> nothing special, I tested the feature using the Home Assistant .ova
> from
> >>>> [1]. Downloaded the OVA to my local storage, pressed "import", did not
> >>>> change *any* settings apart from ticking "live import".
> >>>> The import works, but the VM is not started. Starting the VM manually
> >>>> works fine, also the tasks log does not show anything of concern.
> >>>> In the browser network requests I saw that 'live-restore' is set to
> '1'
> >>>> in the import POST request.
> >>>>
> >>>> [1] https://www.home-assistant.io/installation/alternative/
> >>>
> >>>
> >>> mhmm can reproduce with that ova image, maybe it has something to do
> with our
> >>> ovf import not detecting the main disk?
> >>> (at least here it does not detect any disk)
> >>>
> >>>
> >>
> >> ok two things here:
> >>
> >> * this ova is malformed it seems, it has a HostResource of
> '/disk/vmidsk1' when
> >> the spec says it should be of the form 'ovf:/disk/vmdisk1' which is
> what we look for
> >> (we could make that optional though?)
> >>
> >> * seemingly live-import does not start the vm if there was no disk, but
> AFAICS
> >> this was pre-existing and not something my series introduced (but not
> sure either)
> >>
> >
> > Ah, thanks for the investigation. Maybe it'd be worth to check whether
> > other hypervisors accept the malformed resource definition and then add
> > support to PVE as well if this is the case.
>
>
> Btw. it should work now already, the GNS3 image that Filip linked to in
> his reply
> used the same format, so this seems to be relatively common.
>
> I used the GNS3 one yesterday as test case to integrate some detection
> quirks, I
> also had to accept whitespace in the OVA disk names (we normalize those as
> standard
> PVE volume name through import anyway).
>
> I then also imported A HAOS OVA image, that works in general, but the disk
> was not
> added as boot device, and the disk bus was LSI, I needed to change both to
> make the
> disk available for OVMF. IIRC the OS type was detected "Others" on import,
> I changed
> that, but seems not all defaults changed with it – maybe one could look
> into that?
> HAOS is a common usecase, I alone installed it twice this year, back then
> I had to
> use the qcow2 image and manually import that like a cave man though hehe
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2024-11-20 16:32 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 15:17 Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 01/12] copy OVF.pm from qemu-server Dominik Csapak
2024-11-17 15:50   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 02/12] plugin: dir: implement import content type Dominik Csapak
2024-11-18 12:16   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 03/12] plugin: dir: handle ova files for import Dominik Csapak
2024-11-18 12:17   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 04/12] ovf: improve and simplify path checking code Dominik Csapak
2024-11-18 12:25   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 05/12] ovf: implement parsing the ostype Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 06/12] ovf: implement parsing out firmware type Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 07/12] ovf: implement rudimentary boot order Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 08/12] ovf: implement parsing nics Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 09/12] api: allow ova upload/download Dominik Csapak
2024-11-18 12:42   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 10/12] plugin: enable import for nfs/btrfs/cifs/cephfs/glusterfs Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 11/12] add 'import' content type to 'check_volume_access' Dominik Csapak
2024-11-18 12:58   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH storage v6 12/12] plugin: file_size_info: don't ignore base path with whitespace Dominik Csapak
2024-11-17 15:16   ` Thomas Lamprecht
2024-11-18  7:42     ` Dominik Csapak
2024-11-18  7:48       ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 1/6] disk import: add additional safeguards for imported image files Dominik Csapak
2024-11-18 13:08   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 2/6] api: delete unused OVF.pm Dominik Csapak
2024-11-17 15:18   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 3/6] use OVF from Storage Dominik Csapak
2024-11-17 17:42   ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 4/6] api: create: implement extracting disks when needed for import-from Dominik Csapak
2024-11-18 13:31   ` Fiona Ebner
2024-11-18 13:36     ` Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 5/6] api: create: add 'import-extraction-storage' parameter Dominik Csapak
2024-11-17 16:13   ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH qemu-server v6 6/6] api: check untrusted image files for import content type Dominik Csapak
2024-11-18 14:48   ` Fiona Ebner
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 1/9] ui: fix special 'import' icon for non-esxi storages Dominik Csapak
2024-11-17 16:21   ` [pve-devel] applied: " Thomas Lamprecht
2024-11-18  8:47     ` Dominik Csapak
2024-11-18  9:56       ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 2/9] ui: guest import: add ova-needs-extracting warning text Dominik Csapak
2024-11-17 16:29   ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 3/9] ui: enable import content type for relevant storages Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 4/9] ui: enable upload/download/remove buttons for 'import' type storages Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 5/9] ui: disable 'import' button for non importable formats Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 6/9] ui: import: improve rendering of volume names Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 7/9] ui: guest import: add storage selector for ova extraction storage Dominik Csapak
2024-11-17 16:31   ` Thomas Lamprecht
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 8/9] ui: guest import: change icon/text for non-esxi import storage Dominik Csapak
2024-11-15 15:17 ` [pve-devel] [PATCH manager v6 9/9] ui: import: show size for dir-based storages Dominik Csapak
2024-11-17 16:37 ` [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages Thomas Lamprecht
2024-11-18 13:06 ` Lukas Wagner
2024-11-18 13:18   ` Dominik Csapak
2024-11-18 13:39     ` Lukas Wagner
2024-11-18 13:44       ` Dominik Csapak
2024-11-18 13:53         ` Dominik Csapak
2024-11-19  8:15           ` Lukas Wagner
2024-11-19  8:44             ` Dominik Csapak
2024-11-19  8:48             ` Thomas Lamprecht
2024-11-20 16:32               ` Gilberto Ferreira via pve-devel [this message]
2024-11-20 16:57                 ` Gilberto Ferreira via pve-devel
2024-11-21  8:24                   ` Dominik Csapak
2024-11-21 12:05                     ` Gilberto Ferreira via pve-devel
2024-11-21 12:23                       ` Gilberto Ferreira via pve-devel
2024-11-21 12:34                         ` Fabian Grünbichler
2024-11-18 14:35 ` Daniel Herzig
2024-11-18 15:01   ` Daniel Herzig
2024-11-18 15:33 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.512.1732120371.391.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=gilberto.nunes32@gmail.com \
    --cc=l.wagner@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal