[pve-devel] [PATCH pve-common] tools: fix syscall mknod()

[pve-devel] [PATCH pve-common] tools: fix syscall mknod()

[Jing Luo via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5189 bytes --]

From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-common] tools: fix syscall mknod()
Date: Fri,  7 Jun 2024 18:33:13 +0900
Message-ID: <20240607093933.3882526-2-jing@jing.rocks>

b792e8df81 introduced a bug that can cause this:

Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11

It should be mknod, not SYS_mknod. This caused other pve perl lib failing
to build. I couldn't reproduce this on amd64 build, but I could reproduce this
on arm64 build; however this didn't seem to fix the issue, unless I revert
b792e8df81.

cf: b792e8df81d70cc8fc4bc7d0655313d4a7f40c3d
Signed-off-by: Jing Luo <jing@jing.rocks>
---
 src/PVE/Tools.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 766c809..c2906de 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1753,7 +1753,7 @@ sub mkdirat($$$) {
 
 sub mknod($$$) {
     my ($filename, $mode, $dev) = @_;
-    return syscall(PVE::Syscall::SYS_mknod, $filename, int($mode), int($dev)) == 0;
+    return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0;
 }
 
 sub fchownat($$$$$) {
-- 
2.45.2




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-common] tools: fix syscall mknod()

[Wolfgang Bumiller]

applied, thanks

Interesting how this seems to break on other architectures...

On Fri, Jun 07, 2024 at 06:33:13PM GMT, Jing Luo via pve-devel wrote:
> From: Jing Luo <jing@jing.rocks>
> To: pve-devel@lists.proxmox.com
> Cc: Jing Luo <jing@jing.rocks>
> Subject: [PATCH pve-common] tools: fix syscall mknod()
> Date: Fri,  7 Jun 2024 18:33:13 +0900
> Message-ID: <20240607093933.3882526-2-jing@jing.rocks>
> X-Mailer: git-send-email 2.45.2
> 
> b792e8df81 introduced a bug that can cause this:
> 
> Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11
> 
> It should be mknod, not SYS_mknod. This caused other pve perl lib failing
> to build. I couldn't reproduce this on amd64 build, but I could reproduce this
> on arm64 build; however this didn't seem to fix the issue, unless I revert
> b792e8df81.
> 
> cf: b792e8df81d70cc8fc4bc7d0655313d4a7f40c3d
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
>  src/PVE/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 766c809..c2906de 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -1753,7 +1753,7 @@ sub mkdirat($$$) {
>  
>  sub mknod($$$) {
>      my ($filename, $mode, $dev) = @_;
> -    return syscall(PVE::Syscall::SYS_mknod, $filename, int($mode), int($dev)) == 0;
> +    return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0;
>  }
>  
>  sub fchownat($$$$$) {
> -- 
> 2.45.2


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel