[pve-devel] Continuing on making the VM ID suggestion strategy configurable

[pve-devel] Continuing on making the VM ID suggestion strategy configurable

[Severen Redwood via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4862 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: pve-devel@lists.proxmox.com
Subject: Continuing on making the VM ID suggestion strategy configurable
Date: Fri, 30 Aug 2024 11:08:07 +1200
Message-ID: <tzwlxcv5z7qacnzkaggl6sz67xsg7cpcktyqc4rulh5nnxm7vy@dviin2xi67un>

Hi everyone,

Something I've been running into with PVE is that VM IDs may be re-used
and that the UI will in fact suggest the smallest available ID (via the
`/cluster/nextid` endpoint), regardless of whether that ID has
previously been used or not. This can cause issues with PBS as it keys
backups by VM ID, which is detailed on this Bugzilla issue [1], so for
brevity I won't replicate the discussion here.

There's a patch series [2] from a few months ago which addresses this by
making the VM ID suggestion strategy configurable with the following
options:

1. Use the smallest ID that is not currently in use (current behaviour).
2. Use one greater than the largest ID in use.
3. Use the smallest ID that is neither currently nor previously in use.

In particular, option 3 is the one that would best solve the problem for
me.

However, the patches are stuck on some unresolved feedback and the
author (CC'd in) seems to have either paused or abandoned work on the
feature. For this reason, I'm interested in picking up where they left
off to get the feature to an acceptable state. Is this OK? And how
feasible is it that this feature would ultimately be accepted? At the
moment, the only nontrivial issue raised with the patches seems to be
regarding where the list of previously used VM IDs should be stored,
which I believe should be resolvable.

Thanks,
Severen

[1]: https://bugzilla.proxmox.com/show_bug.cgi?id=4369#c13
[2]: https://lore.proxmox.com/pve-devel/D1RYIAHXBOIH.RM5K01KGND9T@proxmox.com/t/

P.S. This is my first time using a mailing list, so please let me know
about any inadvertent breaches of etiquette :)


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Continuing on making the VM ID suggestion strategy configurable

[Daniel Krambrock via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 8018 bytes --]

From: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] Continuing on making the VM ID suggestion strategy configurable
Date: Mon, 2 Sep 2024 12:44:44 +0200
Message-ID: <30ea0b15-3fe1-43d2-a573-e7d41504371a@hrz.uni-marburg.de>

Hi everyone,

please excuse me for leaving this issue lying around. I am very pleased 
that Severen is interested in continuing this patch and takes over the work.

Am 30.08.24 um 01:08 schrieb Severen Redwood:
> There's a patch series [2] from a few months ago which addresses this by
> making the VM ID suggestion strategy configurable with the following
> options:
> 
> 1. Use the smallest ID that is not currently in use (current behaviour).
> 2. Use one greater than the largest ID in use.
> 3. Use the smallest ID that is neither currently nor previously in use.
> 
> In particular, option 3 is the one that would best solve the problem for
> me.

You are of course right, only option 3 solves the problem as also 
Shannon pointed out.

> However, the patches are stuck on some unresolved feedback and the
> author (CC'd in) seems to have either paused or abandoned work on the
> feature. For this reason, I'm interested in picking up where they left
> off to get the feature to an acceptable state. Is this OK?

For me this is more then OK, thank you. In case it's still important: I 
have already signed the Harmony CLA.

Yours sincerely,
Daniel


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel