public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Peter via pve-devel <pve-devel@lists.proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Peter <pjcreath+proxmox@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC] CentOS, Rocky, Alma 10
Date: Thu, 11 Sep 2025 20:10:01 -0400	[thread overview]
Message-ID: <mailman.467.1757635822.418.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <bab0b966-d4de-4339-ac49-a06619de62ca@proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 8076 bytes --]

From: Peter <pjcreath+proxmox@gmail.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [RFC] CentOS, Rocky, Alma 10
Date: Thu, 11 Sep 2025 20:10:01 -0400
Message-ID: <CADbnQj6WRJqT2dsxFxf3ftYoHkN7vKhjTiSZp6tPK2dJ8fXVRA@mail.gmail.com>

Thanks for pointing me to that patch series!  What kind of testing would
you like me to do, given that you already have some local clean ups?

The one issue I noticed in the patch series was the repeated typo "netork"
instead of "network" in 2/4.

On Wed, Sep 10, 2025 at 4:46 PM Thomas Lamprecht <t.lamprecht@proxmox.com>
wrote:

> Am 10.09.25 um 22:04 schrieb Peter:
> > After seeing the thread on Debian 13.1, I wanted to ask what the process
> is
> > for adding container support for version 10 of the various RHEL families?
>
> Sometimes it's enough to bump the accepted upper version limit, but that
> won't cut it for the RHEL 10 based derivatives, as there the support for
> the network configuration in the ifcfg format we previously used for RHEL
> family got removed.
>
> FWIW there is a patch series that includes the required changes [0], I
> started review and had some local clean ups on top in prepared but not
> yet fully finished. If you, or someone else, can test the mentioned series
> it should help to accelerate things a bit.
>
> [0]:
> https://lore.proxmox.com/all/mailman.338.1755988247.385.pve-devel@lists.proxmox.com/
>
> > As to the mechanics, similar to Trixie, there's a version check that
> blocks
> > installing a container running el10:
> >
> > --- LXC/Setup/CentOS.pm.orig 2025-09-10 15:57:05.961409961 -0400
> >
> > +++ LXC/Setup/CentOS.pm 2025-09-06 16:22:18.589570360 -0400
> >
> > @@ -23,5 +23,5 @@
> >
> >
> >
> >      if (($release =~ m/release\s+(\d+\.\d+)(\.\d+)?/) || ($release =~
> > m/release\s+(\d+)/)) {
> >
> > -        if ($1 >= 5 && $1 < 10) {
> >
> > +        if ($1 >= 5 && $1 < 11) {
> >
> >              $version = $1;
> >
> >          }
> >
> > That lets me install version 10, but then I get a warning each time the
> > container starts.  It turns out the pattern matching for systemd version
> is
> > a little too strict in LXC/Setup/Base.pm:get_systemd_version:
> >
> >             if ($line =~
> > /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/) {
> >
> > This worked fine for version 9 and earlier, as their .so line looked like
> > "libsystemd-shared-256.so".  But as of version 10, the .so line is now "
> > libsystemd-shared-257-9.0.1.el10_0.1.so".  The "el10_0" throws off the
> > regular expression.
> >
> > Would it be preferable to loosen the pattern in Base.pm or to copy
> > get_systemd_version into CentOS.pm and revise the pattern there?
>
> The aforementioned series also addresses this, that patch got already
> applied IIRC:
>
>
> https://lore.proxmox.com/all/mailman.334.1755988211.385.pve-devel@lists.proxmox.com/
>
>

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-09-12  0:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADbnQj4SkX=D+zBN0oMEr1g+K0+oooEU1YWnH5PF-f5vH0NNeQ@mail.gmail.com>
2025-09-10 20:46 ` Thomas Lamprecht
2025-09-12  0:10   ` Peter via pve-devel [this message]
2025-09-10 20:04 Peter via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.467.1757635822.418.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=pjcreath+proxmox@gmail.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal