public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-network 0/1] ipam/netbox prefix fix
@ 2025-07-30 21:26 Trygve Laugstøl via pve-devel
  0 siblings, 0 replies; only message in thread
From: Trygve Laugstøl via pve-devel @ 2025-07-30 21:26 UTC (permalink / raw)
  To: pve-devel; +Cc: Trygve Laugstøl

[-- Attachment #1: Type: message/rfc822, Size: 7417 bytes --]

From: "Trygve Laugstøl" <trygvis@inamo.no>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network 0/1] ipam/netbox prefix fix
Date: Wed, 30 Jul 2025 23:26:13 +0200
Message-ID: <20250730212614.1264010-1-trygvis@inamo.no>

This fixes #6569 [1]. It basically changes the Netbox lookup from a search to a
lookup. In Netbox it is possible to have multiple registrations of the same
prefix as long as they belong to different VRFs, which is a case this patch also
covers.

I'm not entirely sure the current logic by failing if the prefix exists is the
best, it's easy to think of cases where the prefixes would be planned in Netbox
first (either manually or via automation). But I guess that is a discussion for
another day.

This is my first patch to Proxmox, please let me know if I should do things in a
different way. I will sign the CLA in the following days when I have access to a
scanner.

[1]: https://bugzilla.proxmox.com/show_bug.cgi?id=6569
[2]: https://git.proxmox.com/?p=pve-network.git;a=blob;f=src/PVE/Network/SDN/Ipams/NetboxPlugin.pm;h=e118d03e1eb062d0b69cbb53bb7eb875a1e55336;hb=ea6db24afdaf63dedcdd4d74ce97918f7f82b034#l81

Trygve Laugstøl (1):
  fix #6569: ipam: netbox: better prefix lookup

 src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

-- 
2.47.2



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-07-30 21:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-30 21:26 [pve-devel] [PATCH pve-network 0/1] ipam/netbox prefix fix Trygve Laugstøl via pve-devel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal