Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13239 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support
Date: Fri, 6 Jun 2025 09:42:03 +0000
Message-ID: <0605a27428cfb920ffefc51abdfec050a0a6b535.camel@groupe-cyllene.com>

Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel:
> +sub generate_blockdev_drive_aio {
> +    my ($drive, $scfg) = @_;
> +
> +    my $cache_direct = drive_uses_cache_direct($drive, $scfg);
> +    $drive->{aio} = 'threads' if drive_is_cdrom($drive);

>>We didn't force aio=threads for CD-ROMs before. In principle, it
>>could
>>be fine (I'm going with the version guarded approach), but could you
>>provide some rationale for this change?

ah, indeed. I think I'll use the ide.conf test to verify (this is the
only test with cdrom medias attached, and it's using cifs-store, where
io_uring is disabled).

should be io_uring or threads if storage don't support io_uring.

I'll fix it, and improve tests with cdrom on differents storage


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel