From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
"andrew@apalrd.net" <andrew@apalrd.net>
Subject: Re: [pve-devel] [PATCH pve-network 1/1] Update vxlan plugin to emit local tunnel IP
Date: Wed, 9 Oct 2024 14:49:32 +0000 [thread overview]
Message-ID: <mailman.245.1728485405.332.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <mailman.222.1728378819.332.pve-devel@lists.proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 12327 bytes --]
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Cc: "andrew@apalrd.net" <andrew@apalrd.net>
Subject: Re: [pve-devel] [PATCH pve-network 1/1] Update vxlan plugin to emit local tunnel IP
Date: Wed, 9 Oct 2024 14:49:32 +0000
Message-ID: <00a6ee0bf0dfcd9a23bad9ed6ffc7d23bd495e62.camel@groupe-cyllene.com>
patch logic seem to be ok for me. (I don't have tested it)
>>
>> for my $address (@peers) {
>>- next if $address eq $ifaceip;
>>- push @iface_config, "vxlan_remoteip $address";
>>+ push @iface_config, "vxlan_local_tunnelip $address" if $address eq $ifaceip;
>>+ push @iface_config, "vxlan_remoteip $address" if $address ne $ifaceip;
>> }
just be carefull about the identation and maybe use a if/else
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-09 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241008040136.322811-1-andrew@apalrd.net>
2024-10-08 4:01 ` apalrd via pve-devel
2024-10-09 14:49 ` DERUMIER, Alexandre via pve-devel [this message]
[not found] ` <20241008040136.322811-2-andrew@apalrd.net>
2024-10-10 6:21 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.245.1728485405.332.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=andrew@apalrd.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox