public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Rovshan Pashayev via pve-devel <pve-devel@lists.proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: Rovshan Pashayev <Rovshan.Pashayev@veeam.com>
Subject: Re: [pve-devel] Feature Request: Enhancing Error Messaging
Date: Tue, 2 Jul 2024 13:02:23 +0000	[thread overview]
Message-ID: <mailman.216.1719925355.331.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <112887466.2740.1719922786767@webmail.proxmox.com>

[-- Attachment #1: Type: message/rfc822, Size: 13329 bytes --]

From: Rovshan Pashayev <Rovshan.Pashayev@veeam.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>, "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] Feature Request: Enhancing Error Messaging
Date: Tue, 2 Jul 2024 13:02:23 +0000
Message-ID: <PH0PR14MB473525099909EC233147C0759FDC2@PH0PR14MB4735.namprd14.prod.outlook.com>

Hello Fabian,

Example:
If we attempt to start VM with problematic storages from WebUI, we might see following error (example):
https://i.ibb.co/Lx5QjCg/image-2.png

But if we attempt start action via SSH request we get both output in the one line (example):
WARN: no efidisk configured! Using temporary efivars disk. storage 'NFS_pve-storage' does not exist

Which causes confusion, during differentiating errors.

________________________________________
From: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Sent: Tuesday, July 2, 2024 14:19
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Rovshan Pashayev <Rovshan.Pashayev@veeam.com>
Subject: Re: [pve-devel] Feature Request: Enhancing Error Messaging


> Rovshan Pashayev via pve-devel <pve-devel@lists.proxmox.com> hat am 02.07.2024 12:50 CEST geschrieben:

> We kindly request the implementation of enhanced error messaging. Currently, all errors and failures are combined into a single string, making it difficult to identify and address specific issues.

which errors? for which actions/API endpoints/..?

> Please consider introducing error codes or a similar mechanism to provide a structured format for error reporting. This would improve the user experience and expedite troubleshooting during third-party backup processes.

we try to keep the errors meaningful and easy to understand. if you have concrete examples that could benefit from more detail or changed contents, feel free to file issues at https://bugzilla.proxmox.com/

we are not planning to add error codes (like E1234) to our error messages at the moment - in our experience, those don't provide much added benefit at the level of interaction PVE usually provides.

structured error types can make sense for low level interfaces (where callers might decide on a course of action based on the error, like retrying). note that we do differentiate between lacking permissions, bad parameters and other errors also on the API level.


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2024-07-02 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 10:50 Rovshan Pashayev via pve-devel
2024-07-02 12:19 ` Fabian Grünbichler
2024-07-02 13:02   ` Rovshan Pashayev via pve-devel [this message]
     [not found]   ` <PH0PR14MB473525099909EC233147C0759FDC2@PH0PR14MB4735.namprd14.prod.outlook.com>
2024-07-02 13:22     ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.216.1719925355.331.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=Rovshan.Pashayev@veeam.com \
    --cc=f.gruenbichler@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal