Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 13466 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.ebner@proxmox.com" <f.ebner@proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch
Date: Fri, 10 Jan 2025 09:32:15 +0000
Message-ID: <1e45e756801843dd46eb6ce2958d30885ad73bc2.camel@groupe-cyllene.com>

>>Maybe it could even be a bug then? 

Yes, it's a bug.  I just think that libvirt currently only implement 
block-commit with disk blockdev on topnode.

throttle group are not currently implement in libvirt (but I have seen
some commit to add support recently), they still used the old throttle
method.

>>In many situations, the filter >>nodes
>>on top (like throttle groups) are ignored/skipped to get to the
>>actually
>>interesting block node for certain block operations. 

yes, and this option exist in the qmp blockdev-mirror.   (and block-
commit is reusing blockdev-mirror code behind)


>>Are there any situations where you wouldn't want to do that in the
>>block-commit case?
mmm, I think it should always be rettach to disk (format blocknode or
file blocknode if no formatnode exist). I really don't known how to
code this, I have just reused the blockdev-mirror way.


Feel free to cleanup this patch and submit it to qemu devs, you are a
better C developper than me ^_^



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel