public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pve-devel] [PATCH SERIES v2] Add ability to prevent suggesting previously used VM/CT IDs
Date: Fri,  4 Oct 2024 18:07:39 +1300	[thread overview]
Message-ID: <mailman.177.1728018639.332.pve-devel@lists.proxmox.com> (raw)

[-- Attachment #1: Type: message/rfc822, Size: 5192 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>, Dietmar Maurer <dietmar@proxmox.com>
Subject: [PATCH SERIES v2] Add ability to prevent suggesting previously used VM/CT IDs
Date: Fri,  4 Oct 2024 18:07:39 +1300
Message-ID: <20241004050957.441759-1-severen.redwood@sitehost.co.nz>

Hi everyone,

This patch series is an updated version of my previous series [1] adding
optional support for preventing PVE from suggesting previously used
VM/CT IDs.

The ID list is now read into a hash rather than an array so that O(1)
membership tests can be used when `/cluster/nextid` searches for the
next available ID. Consecutive sequences of IDs are also now written to
the disk as ranges to reduce the file size of the ID list. Finally, IDs
are now instead marked as used within the workers that handle deletion,
specifically just before the virtual machine or container's config file
is unlinked.

Thanks,
Severen

[1]: https://lore.proxmox.com/pve-devel/mailman.89.1727359009.332.pve-devel@lists.proxmox.com/T/#u

pve-manager
-----------
Severen Redwood (2):
  close #4369: api: optionally only suggest unique IDs
  close #4369: ui: add datacenter option for unique VM/CT IDs

 PVE/API2/Cluster.pm           | 13 +++++++++++--
 PVE/Makefile                  |  1 +
 PVE/UsedVmidList.pm           | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 www/manager6/dc/OptionView.js |  4 ++++
 4 files changed, 86 insertions(+), 2 deletions(-)
 create mode 100644 PVE/UsedVmidList.pm

pve-container
-------------
Severen Redwood (1):
  api: record CT ID as used after a container is destroyed

 src/PVE/API2/LXC.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

qemu-server
-----------
Severen Redwood (1):
 api: record VM ID as used after a virtual machine is destroyed

  PVE/API2/Qemu.pm | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

pve-cluster
-----------
Severen Redwood (2):
 cluster files: add used_vmids.list
 datacenter config: add unique-next-id to schema

 src/PVE/Cluster.pm          | 1 +
 src/PVE/DataCenterConfig.pm | 5 +++++
 src/pmxcfs/status.c         | 1 +
 3 files changed, 7 insertions(+)


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

             reply	other threads:[~2024-10-04  5:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04  5:07 Severen Redwood via pve-devel [this message]
     [not found] <20241004050957.441759-1-severen.redwood@sitehost.co.nz>
2024-10-30  2:29 ` Severen Redwood via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.177.1728018639.332.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=severen.redwood@sitehost.co.nz \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal