* [pve-devel] [PATCH-SERIES v5 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
@ 2025-04-22 11:51 Alexandre Derumier via pve-devel
0 siblings, 0 replies; only message in thread
From: Alexandre Derumier via pve-devel @ 2025-04-22 11:51 UTC (permalink / raw)
To: pve-devel; +Cc: Alexandre Derumier
[-- Attachment #1: Type: message/rfc822, Size: 9025 bytes --]
From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES v5 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support
Date: Tue, 22 Apr 2025 13:51:21 +0200
Message-ID: <20250422115141.808427-1-alexandre.derumier@groupe-cyllene.com>
This patch series implement qcow2 external snapshot support for files && lvm volumes
The current internal qcow2 snapshots have bad write performance because no metadatas can be preallocated.
This is particulary visible on a shared filesystem like ocfs2 or gfs2.
Also other bugs are freeze/lock reported by users since years on snapshots delete on nfs
(The disk access seem to be frozen during all the delete duration)
This also open doors for remote snapshot export-import for storage replication.
Changelog v5:
pve-storage:
-fix lvm cleanup_worker on removal
- fix Fabian requested changes
qemu-server:
- fix Fabian requested changes
- add suport for iscsi:// blockdev
- convert efidisk && pflash0 to blockdev
- fix cloudinit drive change
- add some units tests for simple rbd,zfs-isci,disk-passthrough
- fix rbd ipv6 monitoring parsing
- fix disk passthrough
- fix qemu-img convert with external snapshot
MAIN TODO:
- convert/implement all the backup code, dirty bitmap mirro, ...
- ceph keyring as blockdev option
- unit tests
Note: Maybe it'll need version guarding finally, as I'm not sure than efidisk && pflash
will be able to live migrate or livemigration+storagemigrate.
(They are already some specific version guard about efidisk size)
I'll look at this for the v6
pve-storage:
Alexandre Derumier (5):
rename_volume: add source && target snap
qcow2: add external snapshot support
lvmplugin: add qcow2 snapshot
storage: vdisk_free: remove external snapshots
volume_has_feature: return storage|qemu_internal|qemu_external
snapshot_type
src/PVE/Storage.pm | 11 +-
src/PVE/Storage/DirPlugin.pm | 1 +
src/PVE/Storage/LVMPlugin.pm | 381 ++++++++++++++++++++++++++++++-----
src/PVE/Storage/Plugin.pm | 320 ++++++++++++++++++++++++-----
src/PVE/Storage/RBDPlugin.pm | 8 +-
5 files changed, 616 insertions(+), 105 deletions(-)
qemu-server
Alexandre Derumier (14):
tests: add cfg2cmd for disk passthrough, rbd,krbd && zfs-over-scsi.
blockdev: cmdline: convert drive to blockdev syntax
blockdev: convert ovmf && efidisk to blockdev
blockdev : convert qemu_driveadd && qemu_drivedel
replace qemu_block_set_io_throttle with qom-set throttlegroup limits
blockdev: vm_devices_list : fix block-query
blockdev: convert cdrom media eject/insert
blockdev: block_resize: convert to blockdev
blockdev: nbd_export: block-export-add : use drive-$id for nodename
blockdev: convert drive_mirror to blockdev_mirror
blockdev: change aio on target if io_uring is not default.
qemu_img convert : add external snapshot support
blockdev: add backing_chain support
qcow2: add external snapshot support
PVE/QemuConfig.pm | 4 +-
PVE/QemuMigrate.pm | 2 +-
PVE/QemuServer.pm | 705 +++++++++---------
PVE/QemuServer/Drive.pm | 461 ++++++++++--
test/MigrationTest/QemuMigrateMock.pm | 10 +-
test/cfg2cmd/bootorder-empty.conf.cmd | 12 +-
test/cfg2cmd/bootorder-legacy.conf.cmd | 12 +-
test/cfg2cmd/bootorder.conf.cmd | 12 +-
...putype-icelake-client-deprecation.conf.cmd | 6 +-
test/cfg2cmd/efi-raw-old.conf.cmd | 7 +-
test/cfg2cmd/efi-raw-template.conf.cmd | 7 +-
test/cfg2cmd/efi-raw.conf.cmd | 7 +-
test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd | 7 +-
test/cfg2cmd/efi-secboot-and-tpm.conf.cmd | 7 +-
test/cfg2cmd/efidisk-on-rbd.conf.cmd | 7 +-
test/cfg2cmd/i440fx-win10-hostpci.conf.cmd | 7 +-
test/cfg2cmd/ide.conf.cmd | 23 +-
test/cfg2cmd/pinned-version-pxe-pve.conf.cmd | 6 +-
test/cfg2cmd/pinned-version-pxe.conf.cmd | 6 +-
test/cfg2cmd/pinned-version.conf.cmd | 6 +-
test/cfg2cmd/q35-ide.conf.cmd | 23 +-
.../q35-linux-hostpci-mapping.conf.cmd | 7 +-
.../q35-linux-hostpci-multifunction.conf.cmd | 7 +-
.../q35-linux-hostpci-template.conf.cmd | 10 +-
...q35-linux-hostpci-x-pci-overrides.conf.cmd | 7 +-
test/cfg2cmd/q35-linux-hostpci.conf.cmd | 7 +-
test/cfg2cmd/q35-simple-6.0.conf.cmd | 7 +-
test/cfg2cmd/q35-simple-7.0.conf.cmd | 7 +-
test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd | 7 +-
test/cfg2cmd/q35-simple.conf.cmd | 7 +-
test/cfg2cmd/q35-win10-hostpci.conf.cmd | 7 +-
test/cfg2cmd/seabios_serial.conf.cmd | 6 +-
test/cfg2cmd/sev-es.conf.cmd | 7 +-
test/cfg2cmd/sev-std.conf.cmd | 7 +-
...imple-balloon-free-page-reporting.conf.cmd | 6 +-
test/cfg2cmd/simple-btrfs.conf.cmd | 6 +-
test/cfg2cmd/simple-disk-passthrough.conf | 15 +
test/cfg2cmd/simple-disk-passthrough.conf.cmd | 40 +
test/cfg2cmd/simple-rbd.conf | 15 +
test/cfg2cmd/simple-rbd.conf.cmd | 38 +
test/cfg2cmd/simple-virtio-blk.conf.cmd | 6 +-
test/cfg2cmd/simple-zfs-over-iscsi.conf | 14 +
test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd | 35 +
test/cfg2cmd/simple1-template.conf.cmd | 11 +-
test/cfg2cmd/simple1.conf.cmd | 6 +-
test/run_config2command_tests.pl | 34 +
46 files changed, 1143 insertions(+), 513 deletions(-)
create mode 100644 test/cfg2cmd/simple-disk-passthrough.conf
create mode 100644 test/cfg2cmd/simple-disk-passthrough.conf.cmd
create mode 100644 test/cfg2cmd/simple-rbd.conf
create mode 100644 test/cfg2cmd/simple-rbd.conf.cmd
create mode 100644 test/cfg2cmd/simple-zfs-over-iscsi.conf
create mode 100644 test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd
Alexandre Derumier (1):
add block-commit-replaces option patch
...074-block-commit-add-replaces-option.patch | 137 ++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 138 insertions(+)
create mode 100644 debian/patches/pve/0074-block-commit-add-replaces-option.patch
--
2.39.5
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-04-22 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-22 11:51 [pve-devel] [PATCH-SERIES v5 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support Alexandre Derumier via pve-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal