From: Roland privat via pve-devel <pve-devel@lists.proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Roland privat <devzero@web.de>,
Alexander Abraham <a.abraham@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-docs] fix #4554: Elaborated on the purpose of different output formats
Date: Mon, 10 Feb 2025 11:53:53 +0100 [thread overview]
Message-ID: <mailman.157.1739185203.293.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <s8objvagjlu.fsf@proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 7889 bytes --]
From: Roland privat <devzero@web.de>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Alexander Abraham <a.abraham@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-docs] fix #4554: Elaborated on the purpose of different output formats
Date: Mon, 10 Feb 2025 11:53:53 +0100
Message-ID: <8117A399-60F9-489F-B1E0-095DCF0F0631@web.de>
perhaps it would be useful to mention, that default output only prints a subset of the available information.
also see https://bugzilla.proxmox.com/show_bug.cgi?id=4554
roland
> Am 10.02.2025 um 11:50 schrieb Maximiliano Sandoval <m.sandoval@proxmox.com>:
>
>
> Some small comments bellow.
>
> Alexander Abraham <a.abraham@proxmox.com> writes:
>
>> Elaborated on the intended differences between the output
>> formats "text" and "json" for the "--output-format" option
>> of the "pvesh" utility.
>>
>> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
>> ---
>> output-format.adoc | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/output-format.adoc b/output-format.adoc
>> index b3eb3c4..cb846ee 100644
>> --- a/output-format.adoc
>> +++ b/output-format.adoc
>> @@ -8,9 +8,15 @@ FORMAT_OPTIONS
>> endif::manvolnum[]
>>
>> It is possible to specify the output format using the
>> -`--output-format` parameter. The default format 'text' uses ASCII-art
>> -to draw nice borders around tables. It additionally transforms some
>> -values into human-readable text, for example:
>> +`--output-format` parameter. The default format, 'text', uses ASCII art
>> +to draw nice borders around tables. Different output formats, such as
>> +"text" or "json", provide different functionality for different use
>> +cases. The `text` output format is supposed to present easily-glanceable
>
> I am not sure if glanceable is correct. I would suggest to rephrase this.
>
>> +information in a human-readable format. The goal of the `json` output
>> +is that the output is parseable and processable by different tools.
>
> This should be "parsable".
>
>> +
>> +The `text` output format additionally transforms some values into
>> +human-readable text, for example:
>>
>> - Unix epoch is displayed as ISO 8601 date string.
>
> "... as a ISO...".
>
>> - Durations are displayed as week/day/hour/minute/second count, i.e `1d 5h`.
>
> "e.g." or "for example" are more appropriate here.
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-10 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 10:30 Alexander Abraham
2025-02-10 10:44 ` Maximiliano Sandoval
2025-02-10 10:53 ` Roland privat via pve-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.157.1739185203.293.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=a.abraham@proxmox.com \
--cc=devzero@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal