From: Alexandre Derumier via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
Subject: [pve-devel] [PATCH FOLLOW-UP storage/qemu-server] external qcow2 snapshot support
Date: Wed, 16 Jul 2025 08:31:35 +0200 [thread overview]
Message-ID: <mailman.1485.1752647526.395.pve-devel@lists.proxmox.com> (raw)
[-- Attachment #1: Type: message/rfc822, Size: 5064 bytes --]
From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH FOLLOW-UP storage/qemu-server] external qcow2 snapshot support
Date: Wed, 16 Jul 2025 08:31:35 +0200
Message-ID: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com>
follow-up patch serie v8
https://lore.proxmox.com/all/39a3339c-d22b-4ec1-b16a-61e5eb91fd53@proxmox.com/T/
Fix Fabian && Wolfgang requests
Major change is the removal $running for volume_snapshot (Thanks Wolgang for the ideas!)
Still need to rework volume_support_qemu_snapshot, I'll not have time to do it before holiday,
so if somebody can help on this, it could be great :)
pve-storage:
Alexandre Derumier (11):
lvm snapshot: activate volume
common: fix qemu_img_resize
plugin: volume_export: don't allow export of external snapshots
lvmplugin: alloc_snap_image: die if file_size_info return empty size
lvmplugin: snapshot: use relative path for backing image
plugin|lvmplugin: don't allow volume rename if external snapshots
exist.
lvmplugin: add volume_snapshot_info
plugin: lvmplugin: add parse_snap_name
plugin : improve parse_namedir warning
lvmplugin: add external-snapshots option && forbid creation of qcow2
volumes without it
storage: remove $running param from volume_snapshot
Fabian Grünbichler (3):
helpers: make qemu_img* storage config independent
helpers: move qemu_img* to Common module
rename_snapshot: fix parameter checks
ApiChangeLog | 4 -
src/PVE/Storage.pm | 7 +-
src/PVE/Storage/Common.pm | 147 ++++++++++++++--
src/PVE/Storage/ESXiPlugin.pm | 2 +-
src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
src/PVE/Storage/LVMPlugin.pm | 115 +++++++++----
src/PVE/Storage/LvmThinPlugin.pm | 2 +-
src/PVE/Storage/PBSPlugin.pm | 2 +-
src/PVE/Storage/Plugin.pm | 239 ++++++++-------------------
src/PVE/Storage/RBDPlugin.pm | 2 +-
src/PVE/Storage/ZFSPoolPlugin.pm | 2 +-
11 files changed, 295 insertions(+), 229 deletions(-)
qemu-server:
Alexandre Derumier (4):
api2: move_disk: use parse_volname to find old volume format
blockdev_rename: remove old left-over rename()
generate_backing_blockdev: use current_sub for private recursive
blockdev_external_snapshot: rework to avoid $running param
src/PVE/API2/Qemu.pm | 5 +----
src/PVE/QemuServer.pm | 38 ++++++----------------------------
src/PVE/QemuServer/Blockdev.pm | 35 ++++++++++++++++++-------------
3 files changed, 28 insertions(+), 50 deletions(-)
--
2.39.5
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-07-16 6:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.1485.1752647526.395.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox