Re: [pve-devel] [RFC pve-manager 0/1] Node maintenance set state for the UI

Re: [pve-devel] [RFC pve-manager 0/1] Node maintenance set state for the UI

[Thomas Skinner]

> From: Tiago Sousa <joao.sousa@eurotux.com>
> To: pve-devel@lists.proxmox.com
> Cc:
> Bcc:
> Date: Mon,  2 Jun 2025 17:10:51 +0100
> Subject: [RFC pve-manager 0/1] Node maintenance set state for the UI
> This patch addresses feature request
> https://bugzilla.proxmox.com/show_bug.cgi?id=6144  to add support for
> setting a node's maintenance state directly from the UI and API.
>
> This implementation uses Sys.PowerMgmt permission for now, but I'm
> unsure if this is the most appropriate. Could there be a better
> permission level?
>
> The API endpoint location at /nodes/{node_name}/node-maintenance-set
> seems logical, but feedback on placement would be appreciated.
>
> Tiago Sousa (1):
>   add ha node maintenance mode to the UI and API
>
>  PVE/API2/Nodes.pm            | 45 ++++++++++++++++++++++++++++++++++++
>  www/manager6/Utils.js        |  1 +
>  www/manager6/node/CmdMenu.js | 36 +++++++++++++++++++++++++++--
>  3 files changed, 80 insertions(+), 2 deletions(-)
>
> --
> 2.39.5

Tiago, I have an implementation of this function in my local PVE 8
branches that we're using. Would it be helpful for me to send over my
patches to you? We have the API implemented under the pve-ha-manager
repo and the HA UI like Thomas Lamprecht was mentioning in the patch
threads. I was going to send my patches in, but I hadn't had a chance
yet until recently. I don't want to step on your toes if you're
working it either.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC pve-manager 0/1] Node maintenance set state for the UI

[Joao Sousa via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5068 bytes --]

From: Joao Sousa <joao.sousa@eurotux.com>
To: Thomas Skinner <thomas@atskinner.net>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [RFC pve-manager 0/1] Node maintenance set state for the UI
Date: Mon, 18 Aug 2025 21:37:16 +0100
Message-ID: <2362dd45-c12e-4ba3-aceb-009e3588fbf8@eurotux.com>

On 8/18/25 5:12 PM, Thomas Skinner wrote:
> Tiago, I have an implementation of this function in my local PVE 8
> branches that we're using. Would it be helpful for me to send over my
> patches to you? We have the API implemented under the pve-ha-manager
> repo and the HA UI like Thomas Lamprecht was mentioning in the patch
> threads. I was going to send my patches in, but I hadn't had a chance
> yet until recently. I don't want to step on your toes if you're
> working it either.


Hello Thomas,

Thanks for reaching out. I haven’t had a chance to revisit this patch 
since I sent it, as I’ve been focused on another series. Please go ahead 
and send your patches.

Best regards,
Tiago


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC pve-manager 0/1] Node maintenance set state for the UI

[Tiago Sousa via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4313 bytes --]

From: Tiago Sousa <joao.sousa@eurotux.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC pve-manager 0/1] Node maintenance set state for the UI
Date: Mon,  2 Jun 2025 17:10:51 +0100
Message-ID: <20250602161052.170879-1-joao.sousa@eurotux.com>

This patch addresses feature request
https://bugzilla.proxmox.com/show_bug.cgi?id=6144  to add support for
setting a node's maintenance state directly from the UI and API.

This implementation uses Sys.PowerMgmt permission for now, but I'm
unsure if this is the most appropriate. Could there be a better
permission level?

The API endpoint location at /nodes/{node_name}/node-maintenance-set
seems logical, but feedback on placement would be appreciated.

Tiago Sousa (1):
  add ha node maintenance mode to the UI and API

 PVE/API2/Nodes.pm            | 45 ++++++++++++++++++++++++++++++++++++
 www/manager6/Utils.js        |  1 +
 www/manager6/node/CmdMenu.js | 36 +++++++++++++++++++++++++++--
 3 files changed, 80 insertions(+), 2 deletions(-)

--
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel