From: "DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Cc: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH FOLLOW-UP storage 1/3] helpers: make qemu_img* storage config independent
Date: Mon, 14 Jul 2025 06:34:38 +0000 [thread overview]
Message-ID: <mailman.1336.1752474917.395.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250710150952.327724-1-f.gruenbichler@proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 13376 bytes --]
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [PATCH FOLLOW-UP storage 1/3] helpers: make qemu_img* storage config independent
Date: Mon, 14 Jul 2025 06:34:38 +0000
Message-ID: <6b7eaeb6af6af22ebdd034236e9e88bc1b5e1e3f.camel@groupe-cyllene.com>
>> sub qemu_img_resize {
>>- my ($scfg, $path, $format, $size, $timeout) = @_;
>>+ my ($scfg, $path, $format, $size, $preallocation, $timeout) =
@_;
you have forgot to remove the $scfg param, so
it's breaking resize for both plugin && lvmplugin
Plugin.pm: PVE::Storage::Common::qemu_img_resize($path, $format,
$size, $preallocation, 10);
LVMPlugin.pm: PVE::Storage::Common::qemu_img_resize($path,
$format, $size, $preallocation, 10);
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-14 6:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 16:21 [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support Alexandre Derumier via pve-devel
2025-07-10 15:09 ` [pve-devel] [PATCH FOLLOW-UP storage 1/3] helpers: make qemu_img* storage config independent Fabian Grünbichler
2025-07-10 15:09 ` [pve-devel] [PATCH FOLLOW-UP storage 2/3] helpers: move qemu_img* to Common module Fabian Grünbichler
2025-07-10 15:09 ` [pve-devel] [PATCH FOLLOW-UP storage 3/3] rename_snapshot: fix parameter checks Fabian Grünbichler
2025-07-14 6:34 ` DERUMIER, Alexandre via pve-devel [this message]
[not found] ` <6b7eaeb6af6af22ebdd034236e9e88bc1b5e1e3f.camel@groupe-cyllene.com>
2025-07-14 11:02 ` [pve-devel] [PATCH FOLLOW-UP storage 1/3] helpers: make qemu_img* storage config independent Fabian Grünbichler
2025-07-10 15:13 ` [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support Fabian Grünbichler
2025-07-10 15:46 ` DERUMIER, Alexandre via pve-devel
[not found] ` <c6c3457906642a30ddffc0f6b9d28ea6a745ac7c.camel@groupe-cyllene.com>
2025-07-10 16:29 ` Thomas Lamprecht
2025-07-11 12:04 ` DERUMIER, Alexandre via pve-devel
2025-07-14 6:25 ` DERUMIER, Alexandre via pve-devel
2025-07-14 8:18 ` DERUMIER, Alexandre via pve-devel
2025-07-14 8:42 ` DERUMIER, Alexandre via pve-devel
[not found] ` <26badbf66613a89e63eaad8b24dd05567900250b.camel@groupe-cyllene.com>
2025-07-14 11:02 ` Fabian Grünbichler
2025-07-15 4:15 ` DERUMIER, Alexandre via pve-devel
[not found] ` <719c71b1148846e0cdd7e5c149d8b20146b4d043.camel@groupe-cyllene.com>
2025-07-14 11:04 ` Fabian Grünbichler
2025-07-14 11:11 ` Thomas Lamprecht
2025-07-14 11:15 ` Fabian Grünbichler
2025-07-14 11:27 ` Thomas Lamprecht
2025-07-14 11:46 ` Fabian Grünbichler
2025-07-14 15:12 ` Tiago Sousa via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.1336.1752474917.395.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=alexandre.derumier@groupe-cyllene.com \
--cc=f.gruenbichler@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox