Re: [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs

[Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 4690 bytes --]

From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,  Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs
Date: Mon, 30 Sep 2024 14:58:51 +1300
Message-ID: <ce6ov3znxweopubjnsw35m5aiboohi2r5yza76brljruxyhbmx@wbnvnhtmvq4v>

On Sun, Sep 29, 2024 at 01:47:31PM GMT, DERUMIER, Alexandre via pve-devel wrote:
> Couldn't we simply move the deleted vm config file
> to a trash/tombstone directory ?
> 
> /etc/pve/.deleted/<vmid>.conf ?
> 
> 
> (I could be great to be able to mass delete vms in // without having a
> big lock on a file)

This is an interesting idea, though I think creating an empty file is
probably better than moving the config as that would only store
information that will never be needed again. Needing to acquire a lock
on the list when deleting multiple VMs may be a bottleneck, but I'm not
entirely convinced it would actually be a problem in practice. How many
VMs do you expect to be deleting all at once? And how often?

This approach would also use more storage as you now have the overhead
of FS metadata for every single ID you have marked as used.

Dietmar, what do you think is the best option here? I'm personally
leaning towards using the list with your run-length encoding suggestion,
but I'm open to implementing Alexandre's idea if you think it's worth
it.


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel