[pve-devel] missing udev properties in PVE9 beta

[pve-devel] missing udev properties in PVE9 beta

[Joshua Huber via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 5594 bytes --]

From: Joshua Huber <jhuber@blockbridge.com>
To: PVE Devel <pve-devel@lists.proxmox.com>
Subject: missing udev properties in PVE9 beta
Date: Fri, 25 Jul 2025 18:01:54 -0400
Message-ID: <CA+uqL03jnaXTaMvzqn-3q274bNhHEuiYQZf0QitdbeKetjG+Dg@mail.gmail.com>

Hi everyone,

While setting up automated testing for PVE9 we noticed that scsi block
devices were missing several udev properties.

After a bit of digging, the root cause turns out to be a regression in
the sg_inq tool (from sg3_utils). This bug slipped in as part of some
refactoring related to json output formatting on Feb 7, 2023.

I filed an issue upstream -- check it out for more details:
https://github.com/doug-gilbert/sg3_utils/issues/63

I also submitted a pull request which fixes the issue:
https://github.com/doug-gilbert/sg3_utils/pull/64

The likelihood of a new upstream release coming in time for the PVE9
release seems quite low. Perhaps a local patch for sg3_utils is in
order?

Take care,
Josh


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] missing udev properties in PVE9 beta

[Thomas Lamprecht]

Hi,

On 26/07/2025 00:01, Joshua Huber wrote:
> While setting up automated testing for PVE9 we noticed that scsi block
> devices were missing several udev properties.
> 
> After a bit of digging, the root cause turns out to be a regression in
> the sg_inq tool (from sg3_utils). This bug slipped in as part of some
> refactoring related to json output formatting on Feb 7, 2023.
> 
> I filed an issue upstream -- check it out for more details:
> https://github.com/doug-gilbert/sg3_utils/issues/63
> 
> I also submitted a pull request which fixes the issue:
> https://github.com/doug-gilbert/sg3_utils/pull/64

Thanks again for the heads up, as mentioned in the forum I also
created a Debian bug report:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109923

And created a merge request with a cherry-pick of this patch
on the Debian package:
https://salsa.debian.org/linux-blocks-team/sg3-utils/-/merge_requests/10

> The likelihood of a new upstream release coming in time for the PVE9
> release seems quite low. Perhaps a local patch for sg3_utils is in
> order?

Yeah, we will take a closer look and pick the fix up for our repos
if nothing comes up.

Thanks!
  Thomas



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] missing udev properties in PVE9 beta

[Joshua Huber via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 6562 bytes --]

From: Joshua Huber <jhuber@blockbridge.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: PVE Devel <pve-devel@lists.proxmox.com>
Subject: Re: missing udev properties in PVE9 beta
Date: Mon, 28 Jul 2025 10:43:24 -0400
Message-ID: <CA+uqL0332oL5B9wBJX8EGLTJ4d-BaYjzuyiMdfSvM_tWJRk4VA@mail.gmail.com>

Hi Thomas,

Fantastic!

Thanks for creating a Debian bug & cherry-picked MR. Fingers crossed
the changes flow through into PVE9. :)

Take care,
Josh

On Sat, Jul 26, 2025 at 8:20 AM Thomas Lamprecht
<t.lamprecht@proxmox.com> wrote:
>
> Hi,
>
> On 26/07/2025 00:01, Joshua Huber wrote:
> > While setting up automated testing for PVE9 we noticed that scsi block
> > devices were missing several udev properties.
> >
> > After a bit of digging, the root cause turns out to be a regression in
> > the sg_inq tool (from sg3_utils). This bug slipped in as part of some
> > refactoring related to json output formatting on Feb 7, 2023.
> >
> > I filed an issue upstream -- check it out for more details:
> > https://github.com/doug-gilbert/sg3_utils/issues/63
> >
> > I also submitted a pull request which fixes the issue:
> > https://github.com/doug-gilbert/sg3_utils/pull/64
>
> Thanks again for the heads up, as mentioned in the forum I also
> created a Debian bug report:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109923
>
> And created a merge request with a cherry-pick of this patch
> on the Debian package:
> https://salsa.debian.org/linux-blocks-team/sg3-utils/-/merge_requests/10
>
> > The likelihood of a new upstream release coming in time for the PVE9
> > release seems quite low. Perhaps a local patch for sg3_utils is in
> > order?
>
> Yeah, we will take a closer look and pick the fix up for our repos
> if nothing comes up.
>
> Thanks!
>   Thomas
>
>


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] missing udev properties in PVE9 beta

[Thomas Lamprecht]

Hi Josh,

Am 28.07.25 um 16:43 schrieb Joshua Huber:
> Thanks for creating a Debian bug & cherry-picked MR. Fingers crossed
> the changes flow through into PVE9. :)

FYI: We just uploaded a build of sg3-utils with your patch included
into the pve-test trixie repo, it's version 1.48-2+pmx1.

I could easily reproduce the issue here and thus test the patch.

E.g., the output of `sq_inq --export` with the original version:

sg_inq --export /dev/sg5
SCSI_TPGS=0
SCSI_TYPE=medium changer
SCSI_VENDOR=QUANTUM
SCSI_VENDOR_ENC=QUANTUM\x20

And after upgrading to the newer version with your patch:

sg_inq --export /dev/sg5
SCSI_TPGS=0
SCSI_TYPE=medium changer
SCSI_VENDOR=QUANTUM
SCSI_VENDOR_ENC=QUANTUM\x20
SCSI_MODEL=UHDL
SCSI_MODEL_ENC=UHDL\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
SCSI_REVISION=0096

Thanks!
 Thomas


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] missing udev properties in PVE9 beta

[Fabian Grünbichler]

On July 29, 2025 1:58 pm, Thomas Lamprecht wrote:
> Hi Josh,
> 
> Am 28.07.25 um 16:43 schrieb Joshua Huber:
>> Thanks for creating a Debian bug & cherry-picked MR. Fingers crossed
>> the changes flow through into PVE9. :)
> 
> FYI: We just uploaded a build of sg3-utils with your patch included
> into the pve-test trixie repo, it's version 1.48-2+pmx1.
> 
> I could easily reproduce the issue here and thus test the patch.
> 
> E.g., the output of `sq_inq --export` with the original version:
> 
> sg_inq --export /dev/sg5
> SCSI_TPGS=0
> SCSI_TYPE=medium changer
> SCSI_VENDOR=QUANTUM
> SCSI_VENDOR_ENC=QUANTUM\x20
> 
> And after upgrading to the newer version with your patch:
> 
> sg_inq --export /dev/sg5
> SCSI_TPGS=0
> SCSI_TYPE=medium changer
> SCSI_VENDOR=QUANTUM
> SCSI_VENDOR_ENC=QUANTUM\x20
> SCSI_MODEL=UHDL
> SCSI_MODEL_ENC=UHDL\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20
> SCSI_REVISION=0096

and while the fix didn't make it into Trixie itself, it's at least
called out in the release notes as an issue to be aware of:

https://www.debian.org/releases/trixie/release-notes/issues.html#udev-properties-from-sg3-utils-missing


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel