Re: [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed

[Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 4329 bytes --]

From: "Severen Redwood" <severen.redwood@sitehost.co.nz>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH container] api: record CT ID as used after a container is destroyed
Date: Mon, 30 Sep 2024 13:24:36 +1300
Message-ID: <D4J6W8WNZVVO.I4L8Y84TQEFT@sitehost.co.nz>

On Fri Sep 27, 2024 at 5:48 AM NZST, Thomas Lamprecht wrote:
> at this point the CT is not yet destroyed, only the worker that tries to destroy
> it is started, destruction can still fail.
>
> It'd be better to place it inside the $realcmd, or even the $code, ideally
> before the actual unlink of the vmid.conf file, as after that happens the
> ID gets free again from the POV of the pmxcfs and thus pve-cluster's VMID
> list that is used by the next-id call.

Thanks for pointing that out! Upon review, that is definitely the wrong
place to add the CT ID to the list. I'll move the call to
`PVE::UsedVmidList::add_vmid` to sit just before the call to
`PVE::LXC::Config->destroy_config` in the `$code` subroutine instead,
which I think is in the vein of your suggestion.


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel