From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>
Subject: Re: [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed
Date: Mon, 30 Sep 2024 13:24:36 +1300 [thread overview]
Message-ID: <mailman.129.1727655893.332.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <d4cf8562-6c30-4938-b731-a1bddf017cbc@proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 4329 bytes --]
From: "Severen Redwood" <severen.redwood@sitehost.co.nz>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH container] api: record CT ID as used after a container is destroyed
Date: Mon, 30 Sep 2024 13:24:36 +1300
Message-ID: <D4J6W8WNZVVO.I4L8Y84TQEFT@sitehost.co.nz>
On Fri Sep 27, 2024 at 5:48 AM NZST, Thomas Lamprecht wrote:
> at this point the CT is not yet destroyed, only the worker that tries to destroy
> it is started, destruction can still fail.
>
> It'd be better to place it inside the $realcmd, or even the $code, ideally
> before the actual unlink of the vmid.conf file, as after that happens the
> ID gets free again from the POV of the pmxcfs and thus pve-cluster's VMID
> list that is used by the next-id call.
Thanks for pointing that out! Upon review, that is definitely the wrong
place to add the CT ID to the list. I'll move the call to
`PVE::UsedVmidList::add_vmid` to sit just before the call to
`PVE::LXC::Config->destroy_config` in the `$code` subroutine instead,
which I think is in the vein of your suggestion.
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-30 0:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240926135516.117065-1-severen.redwood@sitehost.co.nz>
2024-09-26 13:52 ` [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs Severen Redwood via pve-devel
2024-09-26 15:34 ` Dietmar Maurer
2024-09-29 13:47 ` DERUMIER, Alexandre via pve-devel
2024-09-30 1:58 ` Severen Redwood via pve-devel
[not found] ` <ce6ov3znxweopubjnsw35m5aiboohi2r5yza76brljruxyhbmx@wbnvnhtmvq4v>
2024-09-30 7:50 ` Dietmar Maurer
2024-09-30 8:06 ` DERUMIER, Alexandre via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH manager 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH qemu-server] api: record VM ID as used after a virtual machine " Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH cluster 1/2] cluster files: add used_vmids.list Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH cluster 2/2] datacenter config: add unique-next-id to schema Severen Redwood via pve-devel
[not found] ` <20240926135516.117065-4-severen.redwood@sitehost.co.nz>
2024-09-26 17:48 ` [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed Thomas Lamprecht
2024-09-30 0:24 ` Severen Redwood via pve-devel [this message]
[not found] ` <20240926135516.117065-5-severen.redwood@sitehost.co.nz>
2024-09-26 17:53 ` [pve-devel] [PATCH qemu-server] api: record VM ID as used after a virtual machine " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.129.1727655893.332.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=severen.redwood@sitehost.co.nz \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox