From: Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Roland Kammerer <roland.kammerer@linbit.com>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Date: Fri, 7 Feb 2025 13:34:04 +0100 [thread overview]
Message-ID: <mailman.127.1738931654.293.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <56159490.3085.1738919922263@webmail.proxmox.com>
[-- Attachment #1: Type: message/rfc822, Size: 6735 bytes --]
From: Roland Kammerer <roland.kammerer@linbit.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Date: Fri, 7 Feb 2025 13:34:04 +0100
Message-ID: <Z6X9vOv2lCsvTy3o@arm64>
On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote:
>
> > Roland Kammerer via pve-devel <pve-devel@lists.proxmox.com> hat am 07.02.2025 10:02 CET geschrieben:
> > Hi all,
> >
> > rather simple question I guess, but I could not find the answer in
> > https://pve.proxmox.com/wiki/Storage_Plugin_Development and linked
> > documents and looks like my grep foo is lacking today, so here we go:
> > I guess I know what the first hash in the 'content' array is, but what
> > is the second? Actually, why is there a second one?
> >
> > Storage/LVMPlugin.pm:
> > content => [ {images => 1, rootdir => 1}, { images => 1 }]
> >
> > vs.
> >
> > Storage/LvmThinPlugin.pm:
> > content => [ {images => 1, rootdir => 1}, { images => 1, rootdir => 1}]
> >
> > Best, rck
>
> the first one defines the allowed/valid content types, the second the default one(s):
thanks Fabian and Fiona, that explains it.
> we are working on improving the docs and cleaning all of this up!
that is great news, even after maintaining a plugin for some time it
usually takes a deep dive into some core code to actually understand
some of the API. If there is then something to review or give feedback
from an external plugin dev's point of view feel free to explicitly ping
me.
Best, rck
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-07 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 9:02 Roland Kammerer via pve-devel
2025-02-07 9:18 ` Fabian Grünbichler
2025-02-07 12:34 ` Roland Kammerer via pve-devel [this message]
2025-02-12 10:57 ` Fabian Grünbichler
[not found] ` <Z6X9vOv2lCsvTy3o@arm64>
2025-02-25 10:50 ` Max Carrara
2025-03-07 8:24 ` Roland Kammerer via pve-devel
[not found] ` <Z8qtOTycFZpN5bpL@arm64>
2025-03-07 12:01 ` Roland Kammerer via pve-devel
2025-03-12 11:09 ` Max Carrara
2025-02-07 9:19 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.127.1738931654.293.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=roland.kammerer@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal