Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

[Lou Lecrivain via pve-devel <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 14386 bytes --]

From: <Lou.Lecrivain@wdz.de>
To: <h.duerr@proxmox.com>, <lou.lecrivain@orange.fr>, <pve-devel@lists.proxmox.com>
Cc: <jonatan.crystall@gwdg.de>
Subject: Re: [PATCH-SERIES pve-network v3] Add Nautobot IPAM support
Date: Wed, 19 Mar 2025 10:04:26 +0000
Message-ID: <FR2PPF45D006270058794934539A182152985D92@FR2PPF45D006270.DEUP281.PROD.OUTLOOK.COM>

Hannes,

I appreciate the swift review. I talked with my colleague in Cc and there's no
issue with being co-authors. So let's go forward with your proposition. Thank
you for taking care of it!

Best regards
________________________________________
De : Hannes Dürr <h.duerr@proxmox.com>
Envoyé : mercredi 19 mars 2025 10:21
À : lou.lecrivain@orange.fr <lou.lecrivain@orange.fr>; pve-devel@lists.proxmox.com <pve-devel@lists.proxmox.com>
Cc : jonatan.crystall@gwdg.de <jonatan.crystall@gwdg.de>; Lecrivain, Lou (WDZ) <Lou.Lecrivain@wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [PATCH-SERIES pve-network v3] Add Nautobot IPAM support
 
In general the plugin implementation seems sensible, the only thing I
didn't quite understand is the need for `get_status_ip`, more on that
inline.

The series no longer applies to master, as there have been patches that
add a fingerprint parameter to the API request [0].
For testing purposes I have already adapted the code and wanted to ask
if it is okay for you if I continue the patchseries as co-author with my
adjustments?
Of course you both remain registered as author.

[0]
https://git.proxmox.com/?p=pve-network.git;a=commit;h=894d2d33e3b104bcdc8b83e3f205427db93800c3

On 3/6/25 12:08, lou.lecrivain@orange.fr wrote:
> From: Lou Lecrivain <lou.lecrivain@wdz.de>
>
> Following review from Hannes,
>
> I have made some improvements to the form of the code for the pve-network part.
> No functional changes.
>
> Related changes to pve-manager and pve-docs are also included the email thread.
>
> BR
>
> Lou Lecrivain (3):
>    ipam: nautobot: base plugin
>    ipam: nautobot: add testing for nautobot plugin
>    ipam: nautobot: add checks for prefix deletion
>
>   src/PVE/API2/Network/SDN/Ipams.pm             |   1 +
>   src/PVE/Network/SDN/Ipams.pm                  |   3 +
>   src/PVE/Network/SDN/Ipams/Makefile            |   2 +-
>   src/PVE/Network/SDN/Ipams/NautobotPlugin.pm   | 491 ++++++++++++++++++
>   src/test/ipams/nautobot/expected.add_ip       |  11 +
>   .../ipams/nautobot/expected.add_ip_notgateway |  11 +
>   .../ipams/nautobot/expected.add_next_freeip   |  11 +
>   src/test/ipams/nautobot/expected.add_subnet   |  11 +
>   src/test/ipams/nautobot/expected.del_ip       |  11 +
>   src/test/ipams/nautobot/expected.update_ip    |  11 +
>   src/test/ipams/nautobot/ipam_config           |  24 +
>   src/test/ipams/nautobot/sdn_config            |  20 +
>   src/test/ipams/netbox/ipam_config             |   8 +-
>   src/test/ipams/phpipam/ipam_config            |   8 +-
>   14 files changed, 620 insertions(+), 3 deletions(-)
>   create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
>   create mode 100644 src/test/ipams/nautobot/expected.add_ip
>   create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway
>   create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip
>   create mode 100644 src/test/ipams/nautobot/expected.add_subnet
>   create mode 100644 src/test/ipams/nautobot/expected.del_ip
>   create mode 100644 src/test/ipams/nautobot/expected.update_ip
>   create mode 100644 src/test/ipams/nautobot/ipam_config
>   create mode 100644 src/test/ipams/nautobot/sdn_config
>


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel