Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support

["DERUMIER, Alexandre via pve-devel" <pve-devel@lists.proxmox.com>]

[-- Attachment #1: Type: message/rfc822, Size: 14576 bytes --]

From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Date: Tue, 8 Jul 2025 11:37:53 +0000
Message-ID: <e96d21af22a9fc426c5e390a6f459ca3f8e9a7c5.camel@groupe-cyllene.com>

> 
> I think it'll break parsing of already configured storage without
> snapext option ?

>>I don't think it does?

ah , I have tried with
{ fixed => 1 }  only

but it's ok with

{ optional => 1, fixed => 1 }

pvesm set teststorage --snapext 1
update storage failed: can't change value of fixed parameter 'snapext'




> (It's breaking current tests in pve-storage)

>>how?

run_bwlimit_tests.pl

file /etc/pve/storage.cfg line 2 (skip section 'nolimit'): missing
value for required option 'snapext'
file /etc/pve/storage.cfg line 6 (skip section 'd50'): missing value
for required option 'snapext'
file /etc/pve/storage.cfg line 10 (skip section 'd50m40r30'): missing
value for required option 'snapext'
file /etc/pve/storage.cfg line 14 (skip section 'd20m40r30'): missing
value for required option 'snapext'
file /etc/pve/storage.cfg line 18 (skip section 'd200m400r300'):
missing value for required option 'snapext'
file /etc/pve/storage.cfg line 22 (skip section 'd10'): missing value
for required option 'snapext'
file /etc/pve/storage.cfg line 26 (skip section 'm50'): missing value
for required option 'snapext'
file /etc/pve/storage.cfg line 30 (skip section 'd200'): missing value
for required option 'snapext'
Use of uninitialized value $type in hash element at
../PVE/Storage/Plugin.pm line 606, <DATA> line 960.
Use of uninitialized value $type in string eq at
../PVE/Storage/Plugin.pm line 611, <DATA> line 960.
Use of uninitialized value $type in string eq at
../PVE/Storage/Plugin.pm line 611, <DATA> line 960.
Use of uninitialized value $type in string eq at
../PVE/Storage/Plugin.pm line 611, <DATA> line 960.
Use of uninitialized value $type in string eq at
../PVE/Storage/Plugin.pm line 611, <DATA> line 960.
Use of uninitialized value $type in string eq at
../PVE/Storage/Plugin.pm line 611, <DATA> line 960.

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel