From: Till Riedel via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Till Riedel <riedel@teco.edu>
Subject: [pve-devel] [PATCH 1/2] Suppport for LDAP PosixGroups->memberUid
Date: Wed, 16 Apr 2025 22:55:32 +0200 [thread overview]
Message-ID: <mailman.1104.1744871370.359.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20250416205656.153451-1-riedel@teco.edu>
[-- Attachment #1: Type: message/rfc822, Size: 3788 bytes --]
From: Till Riedel <riedel@teco.edu>
To: pve-devel@lists.proxmox.com
Cc: Till Riedel <riedel@teco.edu>
Subject: [PATCH 1/2] Suppport for LDAP PosixGroups->memberUid
Date: Wed, 16 Apr 2025 22:55:32 +0200
Message-ID: <20250416205656.153451-3-riedel@teco.edu>
Signed-off-by: Till Riedel <riedel@teco.edu>
---
src/PVE/LDAP.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LDAP.pm b/src/PVE/LDAP.pm
index 16a0a8e..ab7df3e 100644
--- a/src/PVE/LDAP.pm
+++ b/src/PVE/LDAP.pm
@@ -208,7 +208,7 @@ sub query_groups {
my $page = Net::LDAP::Control::Paged->new(size => 100);
- my $attrs = [ 'member', 'uniqueMember' ];
+ my $attrs = [ '*' ];
push @$attrs, $group_name_attr if $group_name_attr;
my @args = (
base => $base_dn,
@@ -241,6 +241,10 @@ sub query_groups {
if (!scalar(@$members)) {
$members = [$entry->get_value('uniqueMember')];
}
+ if (!scalar(@$members)) {
+ $members = [$entry->get_value('memberUid')];
+ }
+
$group->{members} = $members;
if ($group_name_attr && (my $name = $entry->get_value($group_name_attr))) {
$group->{name} = $name;
--
2.45.1
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-17 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250416205656.153451-1-riedel@teco.edu>
2025-04-16 20:55 ` [pve-devel] [PATCH 0/2] " Till Riedel via pve-devel
2025-04-16 20:55 ` Till Riedel via pve-devel [this message]
2025-04-16 20:55 ` [pve-devel] [PATCH 2/2] " Till Riedel via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.1104.1744871370.359.pve-devel@lists.proxmox.com \
--to=pve-devel@lists.proxmox.com \
--cc=riedel@teco.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal