public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabio Fantoni via pve-devel <pve-devel@lists.proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Fabio Fantoni <fabio.fantoni@m2r.biz>
Subject: Re: [pve-devel] [PATCH qemu-server] fix vm shutdown when agent conf is enabled but is not running in the vm
Date: Mon, 9 Dec 2024 15:00:31 +0100	[thread overview]
Message-ID: <mailman.104.1733762855.332.pve-devel@lists.proxmox.com> (raw)
In-Reply-To: <20241126151957.10072-1-fabio.fantoni@m2r.biz>

[-- Attachment #1: Type: message/rfc822, Size: 6761 bytes --]

From: Fabio Fantoni <fabio.fantoni@m2r.biz>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server] fix vm shutdown when agent conf is enabled but is not running in the vm
Date: Mon, 9 Dec 2024 15:00:31 +0100
Message-ID: <f8f84204-a4ce-4cf6-8626-292a65d33e32@m2r.biz>

Ping

Il 26/11/2024 16:19, Fabio Fantoni ha scritto:
> Checking only vm configuration for choose the shutdown method causes it
> to always fail, after reaching the timeout, if the qemu agent option in
> the vm configuration is enabled but the agent is not installed and
> active in the guest.
> As I seen in the windows vm the agent also crashes in some cases, so
> shutdown don't fail only if qemu guest agent is not installed or not
> started.
>
> Added check that agent is active when choosing agent shutdown method to
> avoid certain shutdown failure in those cases.
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
> ---
>   PVE/QemuServer.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 2046a7c..4b6aac7 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -6341,7 +6341,7 @@ sub _do_vm_stop {
>
>       eval {
>   	if ($shutdown) {
> -	    if (defined($conf) && get_qga_key($conf, 'enabled')) {
> +	    if (defined($conf) && get_qga_key($conf, 'enabled') && qga_check_running($vmid, 1)) {
>   		mon_cmd($vmid, "guest-shutdown", timeout => $timeout);
>   	    } else {
>   		mon_cmd($vmid, "system_powerdown");



--
Questa email è stata esaminata alla ricerca di virus dal software antivirus Avast.
www.avast.com


[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

       reply	other threads:[~2024-12-09 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241126151957.10072-1-fabio.fantoni@m2r.biz>
2024-12-09 14:00 ` Fabio Fantoni via pve-devel [this message]
2024-11-26 15:19 Fabio Fantoni via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mailman.104.1733762855.332.pve-devel@lists.proxmox.com \
    --to=pve-devel@lists.proxmox.com \
    --cc=fabio.fantoni@m2r.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal