From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server] cpu models: only include custom models on x86_64
Date: Tue, 19 May 2026 10:18:37 +0200 [thread overview]
Message-ID: <lutb5457342b2lxcpcdyeapiua7evkdg3qat2azamaw7aimhmm@i2uofd2xewm2> (raw)
In-Reply-To: <51a4715d-b615-4537-ab82-36eeca18345e@proxmox.com>
On Tue, May 19, 2026 at 10:13:47AM +0200, Fiona Ebner wrote:
> Am 19.05.26 um 9:51 AM schrieb Arthur Bied-Charreton:
> > The custom CPU models config does not currently expose a way to specify
> > an arch and it defaults to x86_64.
> >
>
> This is not true? It implicitly defaults to the arch of the base model
> (i.e. reported-model) and custom models for aarch64 can be created and
> used just fine. Just not created via UI.
>
Argh you're right, I misremembered that
>
> > Only include custom models if $arch is set to x86_64 to prevent listing
> > x86_64-only custom models in the CPU model selector for arm VMs.
> >
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
>
> We should rather filter out the models where the base model does not fit
> the arch.
makes sense, will rather do that
next prev parent reply other threads:[~2026-05-19 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 7:51 [PATCH qemu-server] cpu models: only include custom models on x86_64 Arthur Bied-Charreton
2026-05-19 8:13 ` Fiona Ebner
2026-05-19 8:17 ` Fiona Ebner
2026-05-19 8:46 ` Arthur Bied-Charreton
2026-05-19 8:18 ` Arthur Bied-Charreton [this message]
2026-05-19 9:06 ` superseded: " Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lutb5457342b2lxcpcdyeapiua7evkdg3qat2azamaw7aimhmm@i2uofd2xewm2 \
--to=a.bied-charreton@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox