public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 6/9] installation: iso: improve & align wording with pmg-docs
Date: Tue, 5 Mar 2024 13:05:45 +0100	[thread overview]
Message-ID: <ll636hpojv4zyyqjdky3ucede2fzm2qll4eh3nzhmzvasi5mtq@xy4q2nqioytw> (raw)
In-Reply-To: <CZLOI6WWHREK.1MX3TIYZ8KPPS@proxmox.com>

Thanks for the review!

On Tue, Mar 05, 2024 at 09:38:02AM +0100, Gabriel Goller wrote:
> On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote:
> > +When copying and setting up the packages has finished, you can reboot the
> > +server. This will be done automatically after a few seconds by default.
>
> I would remove the `by default` so that the sentence becomes:
>
>     This will be done automatically after a few seconds.

Well, the option to automatically reboot can be changed and is on by
default, so it makes sense IMO to have that bit in there. Although the
sentence can probably be rephrased a bit to make it read easier - I'll
see what I can come up with for v2.

>
> > +. Log in using the `root` (realm 'PAM') username and the password chosen during
> > +installation.
>
> I think you need to fix the indentation here...
>

Will do, although we have (esp. in pmg-docs) a mix-match of both styles,
since it seems not not matter to asciidoc.
I will then probably go about and fix all the other instances too, if
I'm already it at ..

>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>




  reply	other threads:[~2024-03-05 12:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 13:22 [pve-devel] [PATCH docs 0/9] improve & unify installation(-related) documentation Christoph Heiss
2024-03-04 13:22 ` [pve-devel] [PATCH docs 1/9] gitignore: add package build outputs Christoph Heiss
2024-03-06 17:16   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-04 13:22 ` [pve-devel] [PATCH docs 2/9] asciidoc: introduce `pricing-url` variable, much like pmg-docs Christoph Heiss
2024-03-06 17:16   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-04 13:22 ` [pve-devel] [PATCH docs 3/9] local-btrfs: unify casing for btrfs Christoph Heiss
2024-03-06 17:19   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-04 13:22 ` [pve-devel] [PATCH docs 4/9] getting-help: forum: align wording with pmg-docs Christoph Heiss
2024-03-06 17:19   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-04 13:22 ` [pve-devel] [PATCH docs 5/9] package-repos: " Christoph Heiss
2024-03-05  8:28   ` Gabriel Goller
2024-03-05 12:00     ` Christoph Heiss
2024-03-04 13:22 ` [pve-devel] [PATCH docs 6/9] installation: iso: improve & " Christoph Heiss
2024-03-05  8:38   ` Gabriel Goller
2024-03-05 12:05     ` Christoph Heiss [this message]
2024-03-04 13:22 ` [pve-devel] [PATCH docs 7/9] installation: lvm-options: " Christoph Heiss
2024-03-04 13:22 ` [pve-devel] [PATCH docs 8/9] installation: zfs-options: " Christoph Heiss
2024-03-04 13:22 ` [pve-devel] [PATCH docs 9/9] installation: iso: reflow location and password dialog screenshots Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ll636hpojv4zyyqjdky3ucede2fzm2qll4eh3nzhmzvasi5mtq@xy4q2nqioytw \
    --to=c.heiss@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal