public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 0/3] properly filter out all installer-related kernel arguments
Date: Mon, 11 Nov 2024 12:08:45 +0100	[thread overview]
Message-ID: <krmhrpadw2ye3hbdzpfljzkana3s47r2onhenvqw6qrfhkc4i4@jrt3x3ptnanr> (raw)
In-Reply-To: <20240821132307.1352643-1-c.heiss@proxmox.com>

v3 out: https://lore.proxmox.com/pve-devel/20241111110523.261482-1-c.heiss@proxmox.com/

On Wed, Aug 21, 2024 at 03:22:59PM +0200, Christoph Heiss wrote:
> Friedrich recently reported that when installing using the
> auto-installer, the kernel commandline does not get cleaned up properly.
>
> For building/testing on current master, [0] needs to be applied
> beforehand to fix a test failure.
>
> [0] https://lists.proxmox.com/pipermail/pve-devel/2024-July/064815.html
>
> history
> =======
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065070.html
>
> Notable changes v1 -> v2:
>   * parse whole line by splitting and then filtering out individually
>   * add some tests
>
> git diffstat
> ============
>
> Christoph Heiss (3):
>   low level: config: filter out kernel cmdline on word boundaries
>   low level: config: filter out all installer-related kernel arguments
>   test: add test for kernel commandline parsing
>
>  Proxmox/Install/Config.pm    | 11 ++++---
>  test/Makefile                |  7 +++-
>  test/parse-kernel-cmdline.pl | 62 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 75 insertions(+), 5 deletions(-)
>  create mode 100755 test/parse-kernel-cmdline.pl
>
> --
> 2.45.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-11-11 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 13:22 Christoph Heiss
2024-08-21 13:23 ` [pve-devel] [PATCH installer v2 1/3] low level: config: filter out kernel cmdline on word boundaries Christoph Heiss
2024-08-21 13:23 ` [pve-devel] [PATCH installer v2 2/3] low level: config: filter out all installer-related kernel arguments Christoph Heiss
2024-08-21 13:23 ` [pve-devel] [PATCH installer v2 3/3] test: add test for kernel commandline parsing Christoph Heiss
2024-09-25 14:01 ` [pve-devel] [PATCH installer v2 0/3] properly filter out all installer-related kernel arguments Christoph Heiss
2024-11-10 18:38 ` Thomas Lamprecht
2024-11-11 11:08 ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=krmhrpadw2ye3hbdzpfljzkana3s47r2onhenvqw6qrfhkc4i4@jrt3x3ptnanr \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal