From: Christoph Heiss <c.heiss@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 4/4] fetch-answer: use partition label from fetch config instead of hardcoded
Date: Fri, 8 Nov 2024 10:48:53 +0100 [thread overview]
Message-ID: <j5ho54ryfisn2k2p3i2nkspjlwzmimac7rdlcgy3sv6ceguoo6@4ztafzt3hsmj> (raw)
In-Reply-To: <69f3c439-9e9c-4201-b046-b7cbf3884054@proxmox.com>
On Fri, Nov 08, 2024 at 10:30:18AM +0100, Aaron Lauterer wrote:
> On 2024-11-08 10:28, Christoph Heiss wrote:
> > [..]
> > Also, while reading this, seems nowhere is checked whether the
> > user-supplied value is at max 11 characters long -- I'll add that for v2
> > too.
>
> Too be honest, do we need to do that? For the default it is important, but
> users can use other FS that might allow for longer labels and if the kernel
> of the install live system can handle it, all is good.
Right, we aren't really constrained by FAT here! Thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-08 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 11:59 [pve-devel] [PATCH installer 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label Christoph Heiss
2024-10-18 11:59 ` [pve-devel] [PATCH installer 1/4] auto-install-assistant: add new parameter to specify " Christoph Heiss
2024-10-18 11:59 ` [pve-devel] [PATCH installer 2/4] fetch-answer: refactor cli argument parsing Christoph Heiss
2024-10-18 11:59 ` [pve-devel] [PATCH installer 3/4] fetch-answer: partition: also search for exact-matching partition label Christoph Heiss
2024-10-18 11:59 ` [pve-devel] [PATCH installer 4/4] fetch-answer: use partition label from fetch config instead of hardcoded Christoph Heiss
2024-11-07 15:28 ` Aaron Lauterer
2024-11-08 9:28 ` Christoph Heiss
2024-11-08 9:30 ` Aaron Lauterer
2024-11-08 9:48 ` Christoph Heiss [this message]
2024-11-07 15:29 ` [pve-devel] [PATCH installer 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j5ho54ryfisn2k2p3i2nkspjlwzmimac7rdlcgy3sv6ceguoo6@4ztafzt3hsmj \
--to=c.heiss@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox