public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage 6/6] btrfs: note that btrfs_get_subvol_id() function is broken
Date: Mon, 3 Mar 2025 09:04:56 +0100	[thread overview]
Message-ID: <ivzrulbxderdhk4ttz4g5twcpyqtqrhwyclkhe6xruzzp4r2x5@mmprhxtbvxxc> (raw)
In-Reply-To: <20250228145022.73966-7-f.ebner@proxmox.com>

On Fri, Feb 28, 2025 at 03:50:22PM +0100, Fiona Ebner wrote:
> The btrfs_get_subvol_id() function is broken, because the btrfs
> 'subvol show' command is invoked with '-q', so there is no output.
> 
> The function currently has no reachable caller.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/Storage/BTRFSPlugin.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
> index db678cf..e20b36c 100644
> --- a/src/PVE/Storage/BTRFSPlugin.pm
> +++ b/src/PVE/Storage/BTRFSPlugin.pm
> @@ -232,6 +232,7 @@ sub btrfs_cmd {
>      return $msg;
>  }
>  
> +# NOTE: this function is currently boken, because btrfs_cmd uses '-q' so there will be no output.

IMO we should instead comment out this function (and the now-unreachable
call to it in `volume_resize`, or more specifically, everything after
the new `die` in the affected if-branch).
This *is* easily fixed by removing the `-q` from the command - the logic
otherwise works AFAICT, but we don't need this code right now anyway.

>  sub btrfs_get_subvol_id {
>      my ($class, $path) = @_;
>      my $info = $class->btrfs_cmd(['subvolume', 'show', '--', $path]);
> -- 
> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-03  8:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 14:50 [pve-devel] [PATCH-SERIES storage 0/6] unsized subvol regression fix and improvements Fiona Ebner
2025-02-28 14:50 ` [pve-devel] [PATCH storage 1/6] plugin: file size info: be consistent about size of directory subvol Fiona Ebner
2025-02-28 14:50 ` [pve-devel] [PATCH storage 2/6] btrfs: fix volume size info for subvolumes in scalar context Fiona Ebner
2025-03-03  7:31   ` Wolfgang Bumiller
2025-03-03  9:03     ` Fiona Ebner
2025-03-03  9:10       ` Fiona Ebner
2025-02-28 14:50 ` [pve-devel] [PATCH storage 3/6] plugin: volume export formats: avoid superfluous file_size_info() call Fiona Ebner
2025-02-28 14:50 ` [pve-devel] [PATCH storage 4/6] api: volume info: do not fail for zero-sized subvolumes Fiona Ebner
2025-02-28 14:50 ` [pve-devel] [PATCH storage 5/6] btrfs: die early for broken subvolume resize Fiona Ebner
2025-03-03  8:02   ` Wolfgang Bumiller
2025-02-28 14:50 ` [pve-devel] [PATCH storage 6/6] btrfs: note that btrfs_get_subvol_id() function is broken Fiona Ebner
2025-03-03  8:04   ` Wolfgang Bumiller [this message]
2025-03-03  9:25 ` [pve-devel] [PATCH-SERIES storage 0/6] unsized subvol regression fix and improvements Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ivzrulbxderdhk4ttz4g5twcpyqtqrhwyclkhe6xruzzp4r2x5@mmprhxtbvxxc \
    --to=w.bumiller@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal