public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH installer v4 00/12] fix #5536: implement post-(auto-)installation notification mechanism
Date: Tue, 12 Nov 2024 11:33:54 +0100	[thread overview]
Message-ID: <hihhwc65amsvu7elw66syodl7fay7all543xlrui7swtemdndf@4h7ebblilc4w> (raw)
In-Reply-To: <00019f8d-e4f2-420e-892a-b89e8b886748@proxmox.com>

On Mon, Nov 11, 2024 at 06:41:15PM +0100, Thomas Lamprecht wrote:
> Am 11.11.24 um 14:14 schrieb Christoph Heiss:
> > This implements a mechanism for post-installation "notifications" via a
> > POST request [0] when using the auto-installer.
> > [..]
> > Feedback on the post-hook information schema is of course also very much
> > appreciated!
>
> What about adding an X.Y format version? So that we can expand this nicely or
> even rework completely.
> [..]
> One naturally can use the product version for deriving the format version,
> but in the long run that needs more client side handling and mapping than
> a separate format version.

Sure, makes sense! The document format will surely change/get
expanded in the future, so definitely good to have something like this
from the get-go.

I'll send a patch asap, fairly trivial to implement for now anyway.

>
> >
> > It should be noted that some information like DMI is generally very
> > depended on the motherboard/firmware, on what information is actually
> > available and filled-in. So the contents are expected to vary wildly
> > between machines and may also be empty, as in the example below from a
> > VM.
>
> Can we also dump the schema so that this can be added to the docs, or
> at least (linked to) in the wiki of the automated installer?

Of course! Glancing over it, the schema for the JSON that
`proxmox-fetch-answer` is also not explicitly documented - so I'll that
one too.

>
> Also, I figure you already planned to document this in the wiki for the
> next ISO release? Just asking to be sure it won't be overlooked.

Yes! Just waited for this to get applied, i.e. having a finalized
format.

>
> >
> > Diffstat
> > ========
> >
> > Christoph Heiss (12):
> >   debian: strip unused library dependencies
> >   fetch-answer: move http-related code to gated module in
> >     installer-common
> >   tree-wide: convert some more crates to use workspace dependencies
> >   auto-install-assistant: replace `PathBuf` parameters with
> >     `AsRef<Path>`
>
> ^- this one would have done well with some short commit message body,
> even if obvious it will never hurt to state the intention of the commit.

Ack!

>
> >   auto-installer: tests: simplify empty disks check
> >   auto-installer: tests: replace `PathBuf` parameters with `AsRef<Path>`
>
> ^- same here w.r.t. the lack of a short commit message body
>
> >   auto-installer: move `SystemDMI` struct to common crate
> >   auto-installer: answer: factor out answer file reading into function
> >   auto-installer: udevinfo: introduce type alias for udev properties
> >   fix #5536: auto-installer: answer: add `posthook` section
> >   fix #5536: post-hook: add utility for sending notifications after
> >     auto-install
>
> ^- above two might have been better off squashed, but I can get how you
> wanted to separate them, so I kept them as is.

Thanks! Since the second patch, adding the `proxmox-post-hook` tool, was
pretty big already, I'd tried to split off things not immediately
relevant to it. (In a sense that the tool is considered "standalone")


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-11-12 10:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 13:14 [pve-devel] " Christoph Heiss
2024-11-11 13:14 ` [pve-devel] [PATCH installer v4 01/12] debian: strip unused library dependencies Christoph Heiss
2024-11-11 13:14 ` [pve-devel] [PATCH installer v4 02/12] fetch-answer: move http-related code to gated module in installer-common Christoph Heiss
2024-11-11 13:14 ` [pve-devel] [PATCH installer v4 03/12] tree-wide: convert some more crates to use workspace dependencies Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 04/12] auto-install-assistant: replace `PathBuf` parameters with `AsRef<Path>` Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 05/12] auto-installer: tests: simplify empty disks check Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 06/12] auto-installer: tests: replace `PathBuf` parameters with `AsRef<Path>` Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 07/12] auto-installer: move `SystemDMI` struct to common crate Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 08/12] auto-installer: answer: factor out answer file reading into function Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 09/12] auto-installer: udevinfo: introduce type alias for udev properties Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 10/12] fix #5536: auto-installer: answer: add `posthook` section Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 11/12] fix #5536: post-hook: add utility for sending notifications after auto-install Christoph Heiss
2024-11-11 13:15 ` [pve-devel] [PATCH installer v4 12/12] unconfigured.sh: run proxmox-post-hook after successful auto-install Christoph Heiss
2024-11-11 17:41 ` [pve-devel] applied: [PATCH installer v4 00/12] fix #5536: implement post-(auto-)installation notification mechanism Thomas Lamprecht
2024-11-12 10:33   ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hihhwc65amsvu7elw66syodl7fay7all543xlrui7swtemdndf@4h7ebblilc4w \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal