From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v3 2/3] guest: refactor and reuse AgentIPView for containers
Date: Wed, 8 Jan 2025 15:28:14 +0100 [thread overview]
Message-ID: <gypihjhsnctiomyqyzsl4k4zphidc5r3drpray6pyh4scqz52a@dgpkyjnswgrg> (raw)
In-Reply-To: <20250108093314.33490-3-g.goller@proxmox.com>
On 08.01.2025 10:33, Gabriel Goller wrote:
> updateStatus: function(unsuccessful, defaulttext) {
> var me = this;
>- var text = defaulttext || gettext('No network information');
>- var more = false;
>- if (unsuccessful) {
>- text = gettext('Guest Agent not running');
>- } else if (me.agent && me.running) {
>- if (Ext.isArray(me.nics) && me.nics.length) {
>- more = true;
>- var ips = me.getDefaultIps(me.nics);
>- if (ips.length !== 0) {
>- text = ips.join('<br>');
>- }
>- } else if (me.nics && me.nics.error) {
>- text = Ext.String.format(text, me.nics.error.desc);
>- }
>- } else if (me.agent) {
>- text = gettext('Guest Agent not running');
>- } else {
>- text = gettext('No Guest Agent configured');
>- }
>
>- var ipBox = me.down('#ipBox');
>+ me.updateStatusCallback(me, unsuccessful, defaulttext);
>+
>+ var ipBox = ipview.down('#ipBox');
> ipBox.update(text);
>
>- var moreBtn = me.down('#moreBtn');
>+ var moreBtn = ipview.down('#moreBtn');
> moreBtn.setVisible(more);
Oops, this hunk shouldn't be here, sent a v4 fixing it!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-08 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 9:33 [pve-devel] [PATCH container/manager v3 0/3] Show container ip in summary and network tab Gabriel Goller
2025-01-08 9:33 ` [pve-devel] [PATCH manager v3 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-01-08 9:33 ` [pve-devel] [PATCH manager v3 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2025-01-08 14:28 ` Gabriel Goller [this message]
2025-01-08 9:33 ` [pve-devel] [PATCH container v3 3/3] api: return all addresses of an interface Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gypihjhsnctiomyqyzsl4k4zphidc5r3drpray6pyh4scqz52a@dgpkyjnswgrg \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox