public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] installation: reword `nomodeset` section a bit, add link to it
Date: Mon, 26 Feb 2024 12:42:32 +0100	[thread overview]
Message-ID: <gyalrr4kue5z3xrby2tjo7bhg36qx3lkx7u7dp6fxdduqi2juw@azehgq4grrky> (raw)
In-Reply-To: <CZEZ3D6MAY4G.1XT1IH690PBL8@proxmox.com>

Thanks for the review!

On Mon, Feb 26, 2024 at 12:27:13PM +0100, Stefan Sterz wrote:
> On Mon Feb 26, 2024 at 12:20 PM CET, Christoph Heiss wrote:
[..]
> > +[[nomodeset_kernel_param]]
> >  Adding the `nomodeset` Kernel Parameter
> >  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >  Problems may arise on very old or very new hardware due to graphics drivers. If
> > -the installation hangs during the boot. In that case, you can try adding the
> > -`nomodeset` parameter. This prevents the Linux kernel from loading any
> > -graphics drivers and forces it to continue using the BIOS/UEFI-provided
> > -framebuffer.
> > +the installation hangs during the boot, you can try adding the `nomodeset`
> > +parameter. This prevents the Linux kernel from loading any graphics drivers and
> > +forces it to continue using the BIOS/UEFI-provided framebuffer.
> >
>
> nit: "the installation hangs during the boot" doesn't require that
> "the". imo "If the installation hangs during boot, you can..."

Yep, sounds indeed better. I'll send a v2.

>
> otherwise sounds good to me
>
> >  On the {pve} bootloader menu, navigate to 'Install {pve} (Terminal UI)' and
> >  press `e` to edit the entry. Using the arrow keys, navigate to the line starting
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>




      reply	other threads:[~2024-02-26 11:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 11:20 Christoph Heiss
2024-02-26 11:27 ` Stefan Sterz
2024-02-26 11:42   ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gyalrr4kue5z3xrby2tjo7bhg36qx3lkx7u7dp6fxdduqi2juw@azehgq4grrky \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal