Re: [PATCH pve-manager 2/8] ui: CPUModelSelector: Fix dirty state on default

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Thu, Mar 26, 2026 at 10:53:01AM +0100, Fiona Ebner wrote:
> Am 12.03.26 um 9:40 AM schrieb Arthur Bied-Charreton:
> > 'originalValue' is set to null in case it's the default, but getValue
> > returns an empty string. This means that when editing a VM's CPU config
> > when the model is 'default', the form would always be marked dirty.
> > 
> > Original patch:
> > https://lore.proxmox.com/pve-devel/20211028114150.3245864-7-s.reiter@proxmox.com/
> > 
> 
> I wonder if this is (still) needed? If I remove the getValue() function,
> and instead add the following in www/manager6/form/CPUModelSelector.js
> 
>     setValue: function (value) {
> 
>         let me = this;
> 
>         me.callParent([value]);
> 
>         console.log('val: ' + value + ' dirty: ' + me.isDirty());
> 
>     },
> 
> 
> for debugging, it doesn't seem to be dirty when the default is set.
> 
You're right, I cannot reproduce it either. Dropping this in the next
iteration.

[...]