public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Philipp Hufnagl <p.hufnagl@proxmox.com>
Cc: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v4 0/2] fix #474: allow transfer from container/vms
Date: Mon, 14 Aug 2023 12:36:57 +0200	[thread overview]
Message-ID: <gnmtaefkxu7gmp2oco6h2ovzihqjrdtpxmbssfj5h44iurefwu@ltao6nygeais> (raw)
In-Reply-To: <20230810100902.714456-1-p.hufnagl@proxmox.com>

applied, thanks

@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is not checked, or hide them (but when hiding them after
already checking them... it's weird)
Or disable the 'Add' button if a VM with a pool is checked?

On Thu, Aug 10, 2023 at 12:09:00PM +0200, Philipp Hufnagl wrote:
> When a member of 2 pools wants to transfer a
>  vm/container to an other pool they can not do that. The vm/container would
>  have first to be removed form the current pool resulting in a loss of
>  privileges of the pool member for this vm/contianer. This feature introduces
>  a way to transfer a vm between pools, guarded by a checkbox from accidental
>  transfers
> 
> changes to v4:
> * check for allocate permissions of the originating pool
> 
> changes to v3:
> * fix subject typo
> * at version log
> 
> changes to v2:
> * split patch in front and backend
> 
> Philipp Hufnagl (2):
>   fix #474: api: allow transfer from container/vms
>   fix #474: ui: allow transfer from container/vms
> 
>  PVE/API2/Pool.pm                 | 16 ++++++++++++++--
>  www/manager6/grid/PoolMembers.js | 17 ++++++++++++++---
>  2 files changed, 28 insertions(+), 5 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 




  parent reply	other threads:[~2023-08-14 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 10:09 [pve-devel] " Philipp Hufnagl
2023-08-10 10:09 ` [pve-devel] [PATCH manager v4 1/2] fix #474: api: " Philipp Hufnagl
2023-08-10 10:09 ` [pve-devel] [PATCH manager v4 2/2] fix #474: ui: " Philipp Hufnagl
2023-08-14 10:36 ` Wolfgang Bumiller [this message]
2023-08-14 10:42   ` [pve-devel] applied: [PATCH manager v4 0/2] fix #474: " Dominik Csapak
2023-08-24 14:46     ` Thomas Lamprecht
2023-08-30 12:53       ` Philipp Hufnagl
2023-08-31 13:47         ` Thomas Lamprecht
2023-08-30 12:43     ` Philipp Hufnagl
2023-08-30 14:29       ` Dominik Csapak
2023-08-31  8:08         ` Philipp Hufnagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gnmtaefkxu7gmp2oco6h2ovzihqjrdtpxmbssfj5h44iurefwu@ltao6nygeais \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=p.hufnagl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal