From: Gabriel Goller <g.goller@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pve-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH] pve-rs: fabrics: handle missing running-config and no fabrics config
Date: Fri, 14 Nov 2025 12:02:01 +0100 [thread overview]
Message-ID: <g3sisjvmvwhfpnuckxbvl2o7asgyo2rojx7l664df6a7e4c3e6@hl7xlcgqfd2c> (raw)
In-Reply-To: <20251114114922.41c8886c@rosa.proxmox.com>
On 14.11.2025 11:49, Stoiko Ivanov wrote:
> Thanks for tackling this so quickly!
>
> nit: a subject-prefix for the repository is missing.
Ah, sorry about that -- this is proxmox-perl-rs obviously :)
> As I noticed the messages from pvestatd in my journal - I gave this a
> quick spin - it does fix the
> ```
> Nov 14 11:36:26 rosa pvestatd[4474]: network status update error: error parsing running-config: missing field `fabrics` at line 1 column 97
> ```
> logspam for me. I quickly looked through the code and to me it looks like
> it does what it says on the tin.
>
> consider this:
> Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-14 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 10:30 Gabriel Goller
2025-11-14 10:49 ` Stoiko Ivanov
2025-11-14 11:02 ` Gabriel Goller [this message]
2025-11-14 11:01 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g3sisjvmvwhfpnuckxbvl2o7asgyo2rojx7l664df6a7e4c3e6@hl7xlcgqfd2c \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox