From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control] api, auth: fix two typos in user-visible options description
Date: Fri, 22 Nov 2024 13:19:07 +0100 [thread overview]
Message-ID: <fjfb5w247avntmowgior6xaz7h2bkngvnvhqqc7jql2ch4bpje@pebgob5gixho> (raw)
In-Reply-To: <20241021120626.1293427-1-c.heiss@proxmox.com>
v2: https://lore.proxmox.com/pve-devel/20241122102627.521873-1-c.heiss@proxmox.com/T/#u
On Mon, Oct 21, 2024 at 02:06:17PM +0200, Christoph Heiss wrote:
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> src/PVE/API2/AccessControl.pm | 5 +++--
> src/PVE/Auth/Plugin.pm | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2/AccessControl.pm
> index c55a7b3..df644d5 100644
> --- a/src/PVE/API2/AccessControl.pm
> +++ b/src/PVE/API2/AccessControl.pm
> @@ -219,8 +219,9 @@ __PACKAGE__->register_method ({
> maxLength => 64,
> completion => \&PVE::AccessControl::complete_username,
> },
> - realm => get_standard_option('realm', {
> - description => "You can optionally pass the realm using this parameter. Normally the realm is simply added to the username <username>\@<relam>.",
> + realm => get_standard_option('realm', {
> + description => "You can optionally pass the realm using this parameter. "
> + . " Normally the realm is simply added to the username <username>\@<realm>.",
> optional => 1,
> completion => \&PVE::AccessControl::complete_realm,
> }),
> diff --git a/src/PVE/Auth/Plugin.pm b/src/PVE/Auth/Plugin.pm
> index aa3706f..763239f 100755
> --- a/src/PVE/Auth/Plugin.pm
> +++ b/src/PVE/Auth/Plugin.pm
> @@ -59,7 +59,7 @@ PVE::JSONSchema::register_standard_option('sync-scope', {
> });
>
> PVE::JSONSchema::register_standard_option('sync-remove-vanished', {
> - description => "A semicolon-seperated list of things to remove when they or the user"
> + description => "A semicolon-separated list of things to remove when they or the user"
> ." vanishes during a sync. The following values are possible: 'entry' removes the"
> ." user/group when not returned from the sync. 'properties' removes the set"
> ." properties on existing user/group that do not appear in the source (even custom ones)."
> --
> 2.46.0
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-22 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 12:06 Christoph Heiss
2024-11-22 12:19 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fjfb5w247avntmowgior6xaz7h2bkngvnvhqqc7jql2ch4bpje@pebgob5gixho \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox