From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
c.ebner@proxmox.com
Subject: Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter
Date: Thu, 5 Jan 2023 14:59:37 +0100 [thread overview]
Message-ID: <ffaa4c85-f226-2542-8c68-bd3751314f66@proxmox.com> (raw)
In-Reply-To: <e48b11cf-9ec2-1867-35ac-191ec8a855fc@proxmox.com>
Am 05/01/2023 um 14:51 schrieb Fiona Ebner:
>> + my($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log",
>> + $param->{start}, $param->{limit}, undef, $param->{since}, $param->{until});
> Style nit: please use 1 line for each parameter if it gets too long [1]
>
In general we try to adhere to rustfmt style, at least in spirit as not everything
can be mapped to perl. That format has an intermediate step between one arg per line
namely something like:
PVE::Tools::foo(
$bar, $baz, $very_long_argument_bla_bla)
Here, that might still work out if we pull out the $param stuff first, e.g.::
my ($start, $limit, $since, $until) = param->@{qw(start limit since until)};
PVE::Tools::dump_fw_logfile(
"/var/log/pve-firewall.log", $start, $limit, undef, $since, $until)
next prev parent reply other threads:[~2023-01-05 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:18 [pve-devel] [RFC common 0/1] Optional parameters `since` and `until` for firewall log filtering Christian Ebner
2023-01-05 9:18 ` [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter Christian Ebner
2023-01-05 13:51 ` Fiona Ebner
2023-01-05 13:59 ` Thomas Lamprecht [this message]
2023-01-05 14:27 ` Christian Ebner
2023-01-05 9:18 ` [pve-devel] [RFC common 1/1] tools: Add specialized `dump_fw_logfile` for `since` and `until` filtering of firewall logs Christian Ebner
2023-01-05 13:25 ` Wolfgang Bumiller
2023-01-05 14:25 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffaa4c85-f226-2542-8c68-bd3751314f66@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox