From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH storage] volume import: assume target API version is at least 9
Date: Wed, 3 Jul 2024 14:26:08 +0200 [thread overview]
Message-ID: <ff2c7120-5777-41ae-bd2a-5d5c82f835a2@proxmox.com> (raw)
In-Reply-To: <20240610090415.13057-1-f.ebner@proxmox.com>
Am 10.06.24 um 11:04 schrieb Fiona Ebner:
> The storage API version has been bumped to at least 9 since
> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where
> this change will come in, then the target node can be assumed to be
> running either Proxmox VE 8 or, during upgrade, the latest version of
> Proxmox VE 7.4, so it's safe to assume a storage API version of at
> least 9 in all cases.
>
> As reported by Maximiliano, the fact that the 'apiinfo' call was
> guarded with a quiet eval could lead to strange errors for replication
> on a customer system where an SSH connection could not always be
> established, because the target's API version would fall back to 1.
> Because of that, the '-base' argument would be missing for the import
> call on the target which would in turn lead to an error about the
> target ZFS volume already existing (rather than doing an incremental
> sync).
>
> Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
applied, with Max's R-b, thanks for that!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-03 12:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 9:04 [pve-devel] " Fiona Ebner
2024-07-02 17:14 ` Max Carrara
2024-07-03 12:26 ` Fiona Ebner [this message]
2024-07-04 9:52 ` Thomas Lamprecht
2024-07-04 10:28 ` Fiona Ebner
2024-07-04 11:51 ` Thomas Lamprecht
2024-07-04 12:11 ` Fiona Ebner
2024-07-04 17:45 ` Thomas Lamprecht
2024-07-05 8:22 ` Fiona Ebner
2024-07-25 12:38 ` Thomas Lamprecht
2024-07-05 7:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff2c7120-5777-41ae-bd2a-5d5c82f835a2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox