From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v2 container 1/2] Add module for reading state changes from monitor socket
Date: Wed, 9 Sep 2020 21:09:50 +0200 [thread overview]
Message-ID: <ff1e3359-8977-ce7c-d7e4-f6892e0b3fc2@proxmox.com> (raw)
In-Reply-To: <20200908115843.345-1-f.ebner@proxmox.com>
On 08.09.20 13:58, Fabian Ebner wrote:
> Will be used to monitor state changes on container startup.
>
> Co-developed-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> I hard-coded the name of the abstract UNIX socket instead of
> trying to re-implement lxc/monitor.c's lxc_monitor_sock_name
> function. For us, is it true that the lxcpath is always '/varl/lib/lxc'?
> Otherwise this won't always work.
>
> src/PVE/LXC/Makefile | 1 +
> src/PVE/LXC/Monitor.pm | 92 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 93 insertions(+)
> create mode 100644 src/PVE/LXC/Monitor.pm
>
>
applied series, thanks! Wolfgang may improve his variant, e.g., by patching lxc, to avoid
a runtime dependency on the lxc monitor, but until that works out this is 10000x times
better that the current status quo.
prev parent reply other threads:[~2020-09-09 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 11:58 [pve-devel] " Fabian Ebner
2020-09-08 11:58 ` [pve-devel] [PATCH v2 container 2/2] Improve feedback for startup Fabian Ebner
2020-09-09 19:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1e3359-8977-ce7c-d7e4-f6892e0b3fc2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox