From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 qemu-server] fix 4493: cloud-init: fix generated Windows config
Date: Tue, 30 Jul 2024 21:14:29 +0200 [thread overview]
Message-ID: <fedfe42a-dac5-4789-9791-12c90e4cb212@proxmox.com> (raw)
In-Reply-To: <20240730151540.308217-1-m.limbeck@proxmox.com>
Am 30/07/2024 um 17:15 schrieb Mira Limbeck:
> Cloudbase-Init, a cloud-init reimplementation for Windows, supports only
> a subset of the configuration options of cloud-init. Some features
> depend on support by the Metadata Service (ConfigDrive2 here) and have
> further limitations [0].
>
> To support a basic setup the following changes were made:
> - password is saved as plaintext for any Windows guests (ostype)
> - DNS servers are added to each of the interfaces
> - SSH public keys are passed via metadata
>
> Network and metadata generation for Cloudbase-Init is separate from the
> default ConfigDrive2 one so as to not interfere with any other OSes that
> depend on the current ConfigDrive2 implementation.
>
> DNS search domains were removed because Cloudbase-Init's ENI parser
> doesn't handle it at all.
> The password set via `cipassword` is used for the Admin user configured
> in the cloudbase-init.conf in the guest while the `ciuser` parameter is
> ignored. The Admin user has to be set in the cloudbase-init.conf file
> instead.
> Specifying a different user does not work.
>
> For the password to work the `ostype` needs to be any Windows variant
> before `cipassword` is set. Otherwise the password will be encrypted and
> the encrypted password used as plaintext password in the guest.
>
> The `citype` needs to be `configdrive2`, which is the default for
> Windows guests, for the generated configs to be compatible with
> Cloudbase-Init.
>
> [0] https://cloudbase-init.readthedocs.io/en/latest/index.html
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v3:
> - removed `use URI` since we already `use URI::Escape`
> - sent a separate patch adding `liburi-perl` dependency in d/control
> v2:
> - unchanged
>
> PVE/API2/Qemu.pm | 13 ++---
> PVE/QemuServer/Cloudinit.pm | 99 +++++++++++++++++++++++++++++++++++--
> 2 files changed, 101 insertions(+), 11 deletions(-)
>
>
applied series, thanks!
Some tests would be nice for this CI stuff in general though, e.g. taking
in CI properties and mocking the write/apply parts to test if the resulting
output matches our expectation could already be a simple regression test
providing some basic safety net.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-30 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 15:15 [pve-devel] " Mira Limbeck
2024-07-30 15:15 ` [pve-devel] [PATCH v3 docs] cloudinit: add Windows cloudbase-init section Mira Limbeck
2024-07-30 19:14 ` [pve-devel] applied: " Thomas Lamprecht
2024-07-30 19:14 ` Thomas Lamprecht [this message]
2024-07-31 8:02 ` [pve-devel] applied: [PATCH v3 qemu-server] fix 4493: cloud-init: fix generated Windows config Mira Limbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedfe42a-dac5-4789-9791-12c90e4cb212@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox