public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH guest-common] backup job: remove 'notification-policy' and 'notification-target' options
Date: Tue, 24 Jun 2025 13:29:56 +0200	[thread overview]
Message-ID: <fe164de7-8b03-4453-a9f6-faddb17c2918@proxmox.com> (raw)
In-Reply-To: <20250612110616.172416-1-l.wagner@proxmox.com>

Superseded-by: 
https://lore.proxmox.com/all/20250624112817.132312-1-l.wagner@proxmox.com/T/#t

On  2025-06-12 13:06, Lukas Wagner wrote:
> Those were only used in the first iteration of the new notification
> stack, which unfortunately hit pvetest too soon. These two keys have no
> effect and were proactively removed by the GUI when changing
> backup job settings.
> 
> The pve8to9 script will gain a check to check for any left-over keys.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Intended for PVE 9
> 
>  src/PVE/VZDump/Common.pm | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index 8fce316..f816ab0 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -230,19 +230,6 @@ my $confdesc = {
>  	enum => ['auto', 'legacy-sendmail', 'notification-system'],
>  	default => 'auto',
>      },
> -    'notification-policy' => {
> -	type => 'string',
> -	description => "Deprecated: Do not use",
> -	optional => 1,
> -	enum => [ 'always', 'failure', 'never'],
> -	default => 'always',
> -    },
> -    'notification-target' => {
> -	type => 'string',
> -	format => 'pve-configid',
> -	description => "Deprecated: Do not use",
> -	optional => 1,
> -    },
>      tmpdir => {
>  	type => 'string',
>  	description => "Store temporary files to specified directory.",

-- 
- Lukas



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-06-24 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 11:06 [pve-devel] " Lukas Wagner
2025-06-24 11:29 ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe164de7-8b03-4453-a9f6-faddb17c2918@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal