From: Alexander Zeidler <a.zeidler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot
Date: Thu, 18 Apr 2024 17:46:37 +0200 [thread overview]
Message-ID: <fdce385fb06de339349c6dd6833f90bc9304da2a.camel@proxmox.com> (raw)
In-Reply-To: <76e37339-f31e-4660-b7fe-e23d96840e59@proxmox.com>
On Thu, 2024-04-18 at 13:05 +0200, Mira Limbeck wrote:
> On 4/18/24 11:16, Alexander Zeidler wrote:
> > to get a first clue for debugging passthrough and similar issues, when
> > no dmesg output has been provided yet.
> >
> > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> > ---
> > v2:
> > * move away from dmesg base
> > * only print kernel command line (boot times can be added by another patch)
> >
> > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062342.html
> >
> >
> > PVE/Report.pm | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/PVE/Report.pm b/PVE/Report.pm
> > index 53ffdcbb..a8c1cab9 100644
> > --- a/PVE/Report.pm
> > +++ b/PVE/Report.pm
> > @@ -31,6 +31,7 @@ my $init_report_cmds = sub {
> > cmds => [
> > 'hostname',
> > 'date -R',
> > + 'cat /proc/cmdline',
> > 'pveversion --verbose',
> > 'cat /etc/hosts',
> > 'pvesubscription get',
> Tested the whole patch series.
> Looks good so far, especially the cmdline and APT information is nice to
> have.
>
> With the added APT information between subscription info, lscpu and
> /cluster/resources, would it maybe make sense to move `pvesubscription
> get` and `pvesh get /cluster/resources` next to each other,
Good idea.
> and `lscpu`
> to the hardware section where we have all the `dmidecode` output, and
> `lspci`?
Maybe placing `lscpu` above or below the potentially accepted (compact
version) of the new memory output? I think it makes sense to start with the
mainboard, followed by cpu/memory and ending with the extensive `lspci`.
The move of `lscpu` was already discussed in v1 here:
[PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections
https://lists.proxmox.com/pipermail/pve-devel/2024-April/062871.html
but I decided to drop it since it was related to another now dropped change.
> Except for the `dmidecode -t16,17` command needing a space for
> consistency, I'm fine with any of the additions.
> So consider the whole series:
>
> Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
> Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-18 15:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 9:16 Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 2/7] report: create "jobs" section, add `jobs.cfg` Alexander Zeidler
2024-04-18 20:25 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 3/7] report: add `apt-cache policy` to list recognized APT sources Alexander Zeidler
2024-04-18 20:28 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 4/7] report: list held back packages Alexander Zeidler
2024-04-18 20:28 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 5/7] report: overhaul `dmidecode` related output Alexander Zeidler
2024-04-18 10:24 ` Mira Limbeck
2024-04-18 12:30 ` Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots Alexander Zeidler
2024-04-18 10:16 ` Aaron Lauterer
2024-04-18 13:32 ` Alexander Zeidler
2024-04-18 10:20 ` Mira Limbeck
2024-04-18 13:38 ` Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 7/7] report: add recent boot timestamps which may show fencing/crash events Alexander Zeidler
2024-04-18 10:43 ` Mira Limbeck
2024-04-18 15:45 ` Alexander Zeidler
2024-04-19 8:56 ` Mira Limbeck
2024-04-18 9:19 ` [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot Alexander Zeidler
2024-04-18 10:16 ` Aaron Lauterer
2024-04-18 11:05 ` Mira Limbeck
2024-04-18 15:46 ` Alexander Zeidler [this message]
2024-04-18 20:25 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdce385fb06de339349c6dd6833f90bc9304da2a.camel@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox